From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSZwR-00087L-Md for qemu-devel@nongnu.org; Sun, 07 Feb 2016 19:44:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSZwQ-0004oC-KU for qemu-devel@nongnu.org; Sun, 07 Feb 2016 19:44:35 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:52144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSZwQ-0004o3-9K for qemu-devel@nongnu.org; Sun, 07 Feb 2016 19:44:34 -0500 Date: Mon, 8 Feb 2016 10:38:06 +1000 From: David Gibson Message-ID: <20160208003806.GC3702@voom> References: <1452860484-12236-1-git-send-email-david@gibson.dropbear.id.au> <1452860484-12236-3-git-send-email-david@gibson.dropbear.id.au> <874mdqxgdo.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E13BgyNx05feLLmH" Content-Disposition: inline In-Reply-To: <874mdqxgdo.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCHv3 2/4] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mst@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, agraf@suse.de --E13BgyNx05feLLmH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 03, 2016 at 11:00:51AM +0100, Markus Armbruster wrote: > David Gibson writes: >=20 > > At present, the core device model code for 8250-like serial ports > > (serial.c) and the code for serial ports attached to ISA-style legacy IO > > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. > > > > There are lots and lots of embedded platforms that have 8250-like serial > > ports but have never had anything resembling ISA legacy IO. Therefore, > > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > > disabled for platforms where it's not appropriate. > > > > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > > CONFIG_SERIAL is enabled, excepting microblaze, moxie, or32, and > > xtensa. As best as I can tell, those platforms never used legacy ISA, > > and also don't include PCI support (which would allow connection of a > > PCI->ISA bridge and/or a southbridge including legacy ISA serial > > ports). > > > > Signed-off-by: David Gibson > > --- > > default-configs/alpha-softmmu.mak | 1 + > > default-configs/arm-softmmu.mak | 1 + > > default-configs/i386-softmmu.mak | 1 + > > default-configs/mips-softmmu.mak | 1 + > > default-configs/mips64-softmmu.mak | 1 + > > default-configs/mips64el-softmmu.mak | 1 + > > default-configs/mipsel-softmmu.mak | 1 + > > default-configs/ppc-softmmu.mak | 1 + > > default-configs/ppc64-softmmu.mak | 1 + > > default-configs/ppcemb-softmmu.mak | 1 + > > default-configs/sh4-softmmu.mak | 1 + > > default-configs/sh4eb-softmmu.mak | 1 + > > default-configs/sparc64-softmmu.mak | 1 + > > default-configs/x86_64-softmmu.mak | 1 + > > hw/char/Makefile.objs | 3 ++- > > 15 files changed, 16 insertions(+), 1 deletion(-) >=20 > Ignorant question: what about the CONFIG_SERIAL in pci.mak? Should it > trigger CONFIG_SERIAL_ISA, too? If not, should the commit message > explain why not? Ah, yes, it probably should. I think I left it out because many of the PCI platforms also explicitly enable CONFIG_SERIAL, but putting CONFIG_SERIAL_ISA in pci.mak is safer for the time being, we can always turn it off one platform at a time later. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --E13BgyNx05feLLmH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWt+NuAAoJEGw4ysog2bOSWlcQAMwwpJckbECtKvpOOC2F6cTC xmjF3l3TXxdTAyr40fprXl2ByKLxLG89VAS0V7CcfuNBnmlgnPvLvwAuZJ6MnWOw C1SrKistZI+1sSiOrRCOitFFHaDXN/bDYAOuugD+9Vu5zXGchne8qVvup0WHwvz+ WoJbrud0u3iQCc8wUb1QnoNI9JZQODU+V6NUycGoE8obKPf5qfgHbCoPibzRhWMk f58dxbGoDq7VEeQUAQT0LRuwUMtEzjfJNnAnxzerw+oVjfZ5ocC/YpmCYJYEPaBV WQLPUyeP4cN5pEpF9yOaWLNjcfm9fWzgsF21poeo+d956Mt3WJM0NQik22jCwMBw ujwD29BFw9uKRSUJPL/9uG0aiAi6m9jD1m/RtL3iQ932QbqTJ1ndlIbjiE1z2jSO 3/UZ/puZTL4xssFc5qar/JhE/fN4SVjj5zDHnwMdR21lBYrTKReU/cEQzdq+AoEx Q1hdQuzhIYID36z3bf/YKtzvI3zVVWs/pB4M5d3ABNq0BgYxx25NAD4YUera93Ek /DSi5pk0XlSOiD0cx85rfxY4RmHOAozgXrYL06HF/W2PODNGjzO7IyylLVS5WQ8Z Pys7lg//w0GF8B/O3a/duyytdExIVxtPNnm1JocV48U4YeBRgFi7J/lFBCGcc8b3 h+vlJa8tgw49qwTSXrdp =Kubt -----END PGP SIGNATURE----- --E13BgyNx05feLLmH--