From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755185AbcBHD7L (ORCPT ); Sun, 7 Feb 2016 22:59:11 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57831 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753022AbcBHD7K (ORCPT ); Sun, 7 Feb 2016 22:59:10 -0500 Date: Sun, 7 Feb 2016 19:59:09 -0800 From: Greg Kroah-Hartman To: Alexander Kuleshov Cc: Lidza Louina , Daeseok Youn , driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging/dgap: move duplicated code from the dgap_cm.* functions Message-ID: <20160208035909.GA25883@kroah.com> References: <1448473881-9757-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448473881-9757-1-git-send-email-kuleshovmail@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 25, 2015 at 11:51:21PM +0600, Alexander Kuleshov wrote: > The dgap driver contains three functions: dgap_cmdb(), dgap_cmdw() > and dgap_cmdw_exit which are contain duplicated code which waits > if necessary before updating the pointer to limit outstanding > commands. This patch introduces the wait_for_fep_cmds_limit() > function which is will be called from these functions to prevent > code duplication. > > Signed-off-by: Alexander Kuleshov > --- > Forgot Signed-off-by line > > drivers/staging/dgap/dgap.c | 103 ++++++++++++++++---------------------------- > 1 file changed, 37 insertions(+), 66 deletions(-) This driver is now deleted from the kernel tree, sorry :(