Re: [PATCH v2] extensions: libxt_NFQUEUE: Add translation to nft

[Florian Westphal <fw@strlen.de>]

Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> On Sun, Feb 7, 2016 at 2:55 PM, Florian Westphal <fw@strlen.de> wrote:

> > Seems this could be written similar to something like:
> >
> > if (info->flags & NFQ_FLAG_CPU_FANOUT) {
> >         bool sep_needed = info->bypass & NFQ_FLAG_BYPASS;
> >         xt_xlate_add(xl, "%sfanout ", sep_need ? "," : "");
> > ...
> 
> The pointer info used in both the versions (of NFQUEUE_xlate) is for
> different structures. Sadly, this doesn't work as v3 structure doesn't
> have a member for bypass field.

Oh, right.  However bypass & flags overlap -- I think you could just use
info->flags & NFQ_FLAG_BYPASS.

If you look at NFQUEUE_parse_v3() it just calls NFQUEUE_parse_v2() with
the v3 structure.