From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751762AbcBHLSO (ORCPT ); Mon, 8 Feb 2016 06:18:14 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34234 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbcBHLSN (ORCPT ); Mon, 8 Feb 2016 06:18:13 -0500 Date: Mon, 8 Feb 2016 12:18:08 +0100 From: Ingo Molnar To: PaX Team Cc: linux-tip-commits@vger.kernel.org, zhangyanfei@cn.fujitsu.com, wency@cn.fujitsu.com, tglx@linutronix.de, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, imtangchen@gmail.com, spender@grsecurity.net, hpa@zytor.com, tangchen@cn.fujitsu.com, y14sg1@comcast.net, isimatu.yasuaki@jp.fujitsu.com, akpm@linux-foundation.org, izumi.taku@jp.fujitsu.com, laijs@cn.fujitsu.com Subject: Re: [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug () Message-ID: <20160208111808.GA8870@gmail.com> References: <56B86F95.12384.11AF6415@pageexec.freemail.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B86F95.12384.11AF6415@pageexec.freemail.hu> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * PaX Team wrote: > On 8 Feb 2016 at 1:42, tip-bot for Ingo Molnar wrote: > > > for (i = 0; i < numa_meminfo.nr_blks; i++) { > > - struct numa_memblk *mb = &numa_meminfo.blk[i]; > > + struct numa_memblk *mb = numa_meminfo.blk + i; > > > > - memblock_set_node(mb->start, mb->end - mb->start, > > - &memblock.reserved, mb->nid); > > + memblock_set_node(mb->start, mb->end-mb->start, &memblock.reserved, mb->nid); > > if you're not keeping to the 80-char length (no complaints from me on that), could > you also use some whitespace around the '-' operator for more readability? Yeah, like I did it later in the function: + memblock_clear_hotplug(mb->start, mb->end - mb->start); Fixed. Thanks, Ingo