Re: [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

[Bruce Richardson <bruce.richardson@intel.com>]

On Mon, Feb 08, 2016 at 07:53:46AM -0800, Charles (Chas) Williams wrote:
> I am afraid I don't understand what you are asking. This was broken in the
> commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be
> 

Perfect. Generally, when adding a patch which fixes something, we add in a 
"fixes line" into the comment. In this case it would be:

	Fixes: 540a211084a7 ("bnx2x: driver core")

See also: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body

/Bruce

> On 02/08/2016 05:51 AM, Bruce Richardson wrote:
> >On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote:
> >>From: "Charles (Chas) Williams" <ciwillia@brocade.com>
> >>
> >>bnx2x_loop_obtain_resources() returns a struct containing the status and
> >>the error message.  If bnx2x_do_req4pf() fails, it shouldn't return both
> >>of these fields set to 0 indicating failure and no error.
> >>
> >>Further, bnx2x_do_req4pf() needs to be able fail and return NO_RESOURCES
> >>so that bnx2x_loop_obtain_resources() can negotiate reduced resource
> >>requirments.  This requires additional checking around bnx2x_do_req4pf().
> >>
> >>Signed-off-by: Chas Williams <3chas3@gmail.com>
> >>---
> >
> >Hi Chas,
> >
> >can you please provide a commit reference for a fixes line for this patch. [No
> >need for a V2 just for that alone, just the reference is enough to save me
> >diving into the git history. I'll manually add the fixes line when committing
> >to the next-net tree]
> >
> >Maintainers, can you please review this patchset and provide feedback or an ACK.
> >
> >Regards,
> >/Bruce
> >