From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] fix typo for libilclient.so on target
Date: Mon, 8 Feb 2016 16:29:45 +0100 [thread overview]
Message-ID: <20160208162945.3a76ee76@free-electrons.com> (raw)
In-Reply-To: <1454944884-49410-1-git-send-email-michael.schenk@albistechnologies.com>
Dear Schenk, Michael,
On Mon, 8 Feb 2016 16:21:24 +0100, Schenk, Michael wrote:
> Signed-off-by: Schenk, Michael <michael.schenk@albistechnologies.com>
> ---
> package/rpi-userland/rpi-userland.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, I've applied after tweaking two things:
- The commit title, which should always follow the format:
<package>: <description>
And also your commit title was talking about "target", but you're
also fixing the "staging" installation. So all in all, I've changed
the commit title to:
rpi-userland: fix typos in the libilclient.so library installation
For future patches, if you could use this convention for commit
titles, it would be great.
- The author/SoB lines, where for consistency reasons we prefer to
have the first name before the last name. Yes, I know that depending
on your geographical area, the common way of doing this is
different, but Buildroot Git history uses "FirstName LastName
<email>" everywhere, so I've changed this. If you can change your
Git configuration to use this for future patches, it would be great.
Thanks a lot for your contribution!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-08 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 15:21 [Buildroot] [PATCH 1/1] fix typo for libilclient.so on target Schenk, Michael
2016-02-08 15:29 ` Thomas Petazzoni [this message]
2016-02-08 17:32 ` Yann E. MORIN
2016-02-08 20:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208162945.3a76ee76@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.