From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT Date: Mon, 8 Feb 2016 22:48:57 +0100 Message-ID: <20160208214857.GA13673@lunn.ch> References: <1454962873-1941-1-git-send-email-bernhard@bwalle.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1454962873-1941-1-git-send-email-bernhard-X9USDgGjgfuzQB+pC5nmwQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bernhard Walle Cc: fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Feb 08, 2016 at 09:21:13PM +0100, Bernhard Walle wrote: > We need that for a custom hardware that needs the reverse reset > sequence. > > Signed-off-by: Bernhard Walle > --- > Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++ > drivers/net/ethernet/freescale/fec_main.c | 8 ++++++-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt > index a9eb611..a4799ff 100644 > --- a/Documentation/devicetree/bindings/net/fsl-fec.txt > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt > @@ -12,6 +12,9 @@ Optional properties: > only if property "phy-reset-gpios" is available. Missing the property > will have the duration be 1 millisecond. Numbers greater than 1000 are > invalid and 1 millisecond will be used instead. > +- phy-reset-active-low : If present then the reset sequence using the GPIO > + specified in the "phy-reset-gpios" property is reversed (H=reset state, > + L=operation state). Hi Bernhard Maybe at the same time add a comment to phy-reset-gpios that the flags part is ignored, see the none standard phy-reset-active-low property instead. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756571AbcBHVtD (ORCPT ); Mon, 8 Feb 2016 16:49:03 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:52374 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755512AbcBHVtA (ORCPT ); Mon, 8 Feb 2016 16:49:00 -0500 Date: Mon, 8 Feb 2016 22:48:57 +0100 From: Andrew Lunn To: Bernhard Walle Cc: fabio.estevam@freescale.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT Message-ID: <20160208214857.GA13673@lunn.ch> References: <1454962873-1941-1-git-send-email-bernhard@bwalle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454962873-1941-1-git-send-email-bernhard@bwalle.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2016 at 09:21:13PM +0100, Bernhard Walle wrote: > We need that for a custom hardware that needs the reverse reset > sequence. > > Signed-off-by: Bernhard Walle > --- > Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++ > drivers/net/ethernet/freescale/fec_main.c | 8 ++++++-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt > index a9eb611..a4799ff 100644 > --- a/Documentation/devicetree/bindings/net/fsl-fec.txt > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt > @@ -12,6 +12,9 @@ Optional properties: > only if property "phy-reset-gpios" is available. Missing the property > will have the duration be 1 millisecond. Numbers greater than 1000 are > invalid and 1 millisecond will be used instead. > +- phy-reset-active-low : If present then the reset sequence using the GPIO > + specified in the "phy-reset-gpios" property is reversed (H=reset state, > + L=operation state). Hi Bernhard Maybe at the same time add a comment to phy-reset-gpios that the flags part is ignored, see the none standard phy-reset-active-low property instead. Andrew