From: "Michael Büsch" <m@bues.ch>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org,
Chaoming Li <chaoming_li@realsil.com.cn>,
b43-dev@lists.infradead.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: [PATCH 1/2] b43: Remove unnecessary synchronize_irq() before free_irq()
Date: Mon, 8 Feb 2016 23:22:02 +0100 [thread overview]
Message-ID: <20160208232202.7db42b54@wiggum> (raw)
In-Reply-To: <1454964073-25108-1-git-send-email-lars@metafoo.de>
On Mon, 8 Feb 2016 21:41:12 +0100
Lars-Peter Clausen <lars@metafoo.de> wrote:
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered,
Well, that depends on whether the interrupt is shared and whether we
disabled the interrupt mask inside of the device (which we did).
> on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.
Ok, fair enough.
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20160208/9a3d5f46/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org,
Chaoming Li <chaoming_li@realsil.com.cn>,
b43-dev@lists.infradead.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 1/2] b43: Remove unnecessary synchronize_irq() before free_irq()
Date: Mon, 8 Feb 2016 23:22:02 +0100 [thread overview]
Message-ID: <20160208232202.7db42b54@wiggum> (raw)
In-Reply-To: <1454964073-25108-1-git-send-email-lars@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Mon, 8 Feb 2016 21:41:12 +0100
Lars-Peter Clausen <lars@metafoo.de> wrote:
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered,
Well, that depends on whether the interrupt is shared and whether we
disabled the interrupt mask inside of the device (which we did).
> on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.
Ok, fair enough.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-08 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 20:41 [PATCH 1/2] b43: Remove unnecessary synchronize_irq() before free_irq() Lars-Peter Clausen
2016-02-08 20:41 ` [PATCH 2/2] rtlwifi: " Lars-Peter Clausen
2016-02-08 21:44 ` Larry Finger
2016-02-08 21:44 ` Larry Finger
2016-02-08 22:22 ` Michael Büsch [this message]
2016-02-08 22:22 ` [PATCH 1/2] b43: " Michael Büsch
2016-02-25 10:00 ` [1/2] " Kalle Valo
2016-02-25 10:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208232202.7db42b54@wiggum \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=chaoming_li@realsil.com.cn \
--cc=kvalo@codeaurora.org \
--cc=lars@metafoo.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.