From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Date: Tue, 9 Feb 2016 10:45:26 +0100 Message-ID: <20160209094526.GB25268@gmail.com> References: <1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=raMgzhi7/UFAUTHc1SVMQOb0g4ha9BlnNq/mqYh7Y5w=; b=QJO5KCsUqjygViZBZSEfMIGW4Kqf1txhT2KUMbzxVgMVc7THCv2XnJ1WBlwqMRSwJi uCuFscGfvFxmhbPoyNKd9ngce99sDFMmlr8k7lMcYx/gHJQMjWki3fme3bDOLKRR5r+x MQcFuQmdiuuRBVWSbJtJ1ky0uJBKFh2VJqBrez8VYv8ApLFXYwqbMufq4vJj+4LYiz9R wU4kyv15mAnPkldNSE2vwcOkPE4oq6q7t3rhaKzEnpzC15y6wyTJy4M9xUiN7YXBJOvS 7tcyoto7jILby9j6VKsFNbCeCSuTZga/hBPPI8HquMqWYFHeXgLwn3rvLnobKnhiFFSb cymw== Content-Disposition: inline In-Reply-To: <1455010600.13384.3.camel@ellerman.id.au> Sender: linux-sh-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michael Ellerman Cc: Andrew Morton , David Long , "H. Peter Anvin" , "chengang@emindsoft.com.cn" , Andy Lutomirski , Benjamin Herrenschmidt , Borislav Petkov , Brian Gerst , David Hildenbrand , Denys Vlasenko , Heiko Carstens , Hendrik Brueckner , Ingo Molnar , Jan Beulich , Kees Cook , Martin Schwidefsky , Oleg Nesterov , Paul Mackerras , Rashmica Gupta , Rich Felker , Richard Kuo , Roland McGrath , Russell King * Michael Ellerman wrote: > On Tue, 2016-02-09 at 00:38 -0500, David Long wrote: > > > From: "David A. Long" > > > > Move duplicate and functionally equivalent code for accessing registers > > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into > > common kernel files. > > > > I'm sending this out again (with updated distribution list) because v2 > > just never got pulled in, even though I don't think there were any > > outstanding issues. > > A big cross arch patch like this would often get taken by Andrew Morton, but > AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for > us :D The other problem is that the second patch is commingling changes to 6 separate architectures: 16 files changed, 106 insertions(+), 343 deletions(-) that should probably be 6 separate patches. Easier to review, easier to bisect to, easier to revert, etc. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Date: Tue, 09 Feb 2016 09:45:26 +0000 Subject: Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Message-Id: <20160209094526.GB25268@gmail.com> List-Id: References: <1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au> In-Reply-To: <1455010600.13384.3.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org * Michael Ellerman wrote: > On Tue, 2016-02-09 at 00:38 -0500, David Long wrote: > > > From: "David A. Long" > > > > Move duplicate and functionally equivalent code for accessing registers > > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into > > common kernel files. > > > > I'm sending this out again (with updated distribution list) because v2 > > just never got pulled in, even though I don't think there were any > > outstanding issues. > > A big cross arch patch like this would often get taken by Andrew Morton, but > AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for > us :D The other problem is that the second patch is commingling changes to 6 separate architectures: 16 files changed, 106 insertions(+), 343 deletions(-) that should probably be 6 separate patches. Easier to review, easier to bisect to, easier to revert, etc. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CFC891A0310 for ; Tue, 9 Feb 2016 20:45:33 +1100 (AEDT) Received: by mail-wm0-x241.google.com with SMTP id 128so2316881wmz.3 for ; Tue, 09 Feb 2016 01:45:33 -0800 (PST) Sender: Ingo Molnar Date: Tue, 9 Feb 2016 10:45:26 +0100 From: Ingo Molnar To: Michael Ellerman Cc: Andrew Morton , David Long , "H. Peter Anvin" , "chengang@emindsoft.com.cn" , Andy Lutomirski , Benjamin Herrenschmidt , Borislav Petkov , Brian Gerst , David Hildenbrand , Denys Vlasenko , Heiko Carstens , Hendrik Brueckner , Ingo Molnar , Jan Beulich , Kees Cook , Martin Schwidefsky , Oleg Nesterov , Paul Mackerras , Rashmica Gupta , Rich Felker , Richard Kuo , Roland McGrath , Russell King , Thomas Gleixner , Will Deacon , Yoshinori Sato , linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Message-ID: <20160209094526.GB25268@gmail.com> References: <1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1455010600.13384.3.camel@ellerman.id.au> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Michael Ellerman wrote: > On Tue, 2016-02-09 at 00:38 -0500, David Long wrote: > > > From: "David A. Long" > > > > Move duplicate and functionally equivalent code for accessing registers > > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into > > common kernel files. > > > > I'm sending this out again (with updated distribution list) because v2 > > just never got pulled in, even though I don't think there were any > > outstanding issues. > > A big cross arch patch like this would often get taken by Andrew Morton, but > AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for > us :D The other problem is that the second patch is commingling changes to 6 separate architectures: 16 files changed, 106 insertions(+), 343 deletions(-) that should probably be 6 separate patches. Easier to review, easier to bisect to, easier to revert, etc. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 From: mingo@kernel.org (Ingo Molnar) Date: Tue, 9 Feb 2016 10:45:26 +0100 Subject: [PATCH v3 0/2] Consolidate redundant register/stack access code In-Reply-To: <1455010600.13384.3.camel@ellerman.id.au> References: <1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au> Message-ID: <20160209094526.GB25268@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Michael Ellerman wrote: > On Tue, 2016-02-09 at 00:38 -0500, David Long wrote: > > > From: "David A. Long" > > > > Move duplicate and functionally equivalent code for accessing registers > > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into > > common kernel files. > > > > I'm sending this out again (with updated distribution list) because v2 > > just never got pulled in, even though I don't think there were any > > outstanding issues. > > A big cross arch patch like this would often get taken by Andrew Morton, but > AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for > us :D The other problem is that the second patch is commingling changes to 6 separate architectures: 16 files changed, 106 insertions(+), 343 deletions(-) that should probably be 6 separate patches. Easier to review, easier to bisect to, easier to revert, etc. Thanks, Ingo