From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT5at-0003qI-RG for qemu-devel@nongnu.org; Tue, 09 Feb 2016 05:32:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aT5at-0003dP-3T for qemu-devel@nongnu.org; Tue, 09 Feb 2016 05:32:27 -0500 Date: Tue, 9 Feb 2016 11:32:20 +0100 From: Kevin Wolf Message-ID: <20160209103220.GC8554@noname.redhat.com> References: <7bfce913f68d95284746e7cf3693703f5361b26f.1454940776.git.berto@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bfce913f68d95284746e7cf3693703f5361b26f.1454940776.git.berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH 1/3] block: Allow x-blockdev-del on a BB with a monitor-owned BDS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Am 08.02.2016 um 15:14 hat Alberto Garcia geschrieben: > When x-blockdev-del is performed on a BlockBackend that has inserted > media it will only succeed if the BDS doesn't have any additional > references. > > The only problem with this is that if the BDS was created separately > using blockdev-add then the backend won't be able to be destroyed > unless the BDS is ejected first. This is an unnecessary restriction. > > Now that we have a list of monitor-owned BDSs we can allow > x-blockdev-del to work in this scenario if the BDS has exactly one > extra reference and that reference is from the monitor. > > Signed-off-by: Alberto Garcia This means that what you created with two blockdev-add commands would be destroyed with a single blockdev-del command. I think we all agreed that blockdev-add and blockdev-del should always come in pairs. Kevin