From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756155AbcBINSn (ORCPT ); Tue, 9 Feb 2016 08:18:43 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33702 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbcBINSm (ORCPT ); Tue, 9 Feb 2016 08:18:42 -0500 Date: Tue, 9 Feb 2016 14:18:38 +0100 From: Ingo Molnar To: Alexander Kuleshov Cc: Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" , Andrey Ryabinin , Andy Lutomirski , Andy Shevchenko , Alexander Popov , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/head64: micro optimization: use memset instead of for loop Message-ID: <20160209131838.GA22486@gmail.com> References: <20160209122809.GA5186@gmail.com> <1455023517-7620-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455023517-7620-1-git-send-email-kuleshovmail@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Alexander Kuleshov wrote: > This patch simplifies clearing of page table directories, by > the using of the fast memset() from the arch/x86/lib/memset_64.S. > Besides this, we 25 bytes is 25 bytes less than original. > > text data bss dec hex filename > > 9735144 4970776 15474688 30180608 1cc8500 vmlinux.old > 9735119 4970776 15474688 30180583 1cc84e7 vmlinux > > Signed-off-by: Alexander Kuleshov > --- > Changelog: > > v2: We got sizeof pud_p/pmd_p in the v1, but actually we need > to take sizeof of pud_p/pmd_p pointer, although their sizes are > the same. Please send a delta patch (with changelog) as the v1 commit is already deep within the tip:x86/boot branch. Thanks, Ingo