From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756780AbcBINxu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Feb 2016 08:53:50 -0500
Received: from mail-wm0-f65.google.com ([74.125.82.65]:34018 "EHLO
	mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755012AbcBINxs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Feb 2016 08:53:48 -0500
Date: Tue, 9 Feb 2016 14:53:44 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andy Lutomirski <luto@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Alexander Popov <alpopov@ptsecurity.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/head64: use pointer type in sizeof
Message-ID: <20160209135344.GA26641@gmail.com>
References: <1455025494-4063-1-git-send-email-kuleshovmail@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1455025494-4063-1-git-send-email-kuleshovmail@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> We changed loops with memset in the 5e9ebbd87a99 commit (x86/boot:
> Micro-optimize reset_early_page_tables()). The base for size of
> memset was size of pud_p/pmd_p, but the they are actually
> represented as pointers, although they have the same sizes.

That's rather confused. Also the title is confused:

  x86/head64: use pointer type in sizeof

what the fix does it to _not_ use a pointer type.

I fixed the title and the changelog, but you really need to be more careful...

Thanks,

	Ingo