From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3 03/21] IB/srpt: Remove struct srpt_node_acl Date: Tue, 9 Feb 2016 16:08:54 +0100 Message-ID: <20160209150854.GA27614@lst.de> References: <56B3D453.7030409@sandisk.com> <56B3D4D7.8060800@sandisk.com> <20160209131507.GA25849@lst.de> <56B9FFD8.2040809@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56B9FFD8.2040809-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: Christoph Hellwig , Doug Ledford , Sagi Grimberg , Alex Estrin , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, Feb 09, 2016 at 07:03:52AM -0800, Bart Van Assche wrote: > On 02/09/16 05:15, Christoph Hellwig wrote: >>> - .node_acl_size = sizeof(struct srpt_node_acl), >>> + .node_acl_size = sizeof(struct se_node_acl), >> >> just drop this line entirely, the core code will do the right thing. > > Hello Christoph, > > Can you show me the code in the LIO core that handles not specifying > .node_acl_size ? I have tried to find it but haven't found it yet. static struct se_node_acl *target_alloc_node_acl(struct se_portal_group *tpg, const unsigned char *initiatorname) { struct se_node_acl *acl; u32 queue_depth; acl = kzalloc(max(sizeof(*acl), tpg->se_tpg_tfo->node_acl_size), GFP_KERNEL); -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html