All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Stephane Eranian <eranian@google.com>,
	Vince Weaver <vincent.weaver@maine.edu>
Subject: [patch 2/4] perf: Remove the bogus and dangerous CPU_DOWN_FAILED hotplug state
Date: Tue, 09 Feb 2016 20:11:26 -0000	[thread overview]
Message-ID: <20160209201007.763417379@linutronix.de> (raw)
In-Reply-To: 20160209200747.893426063@linutronix.de

[-- Attachment #1: perf--Remove-the-bogus-and-dangerous-CPU_DOWN_FAILED-hotplug-state.patch --]
[-- Type: text/plain, Size: 840 bytes --]

If CPU_DOWN_PREPARE fails the perf hotplug notifier is called for
CPU_DOWN_FAILED and calls perf_event_init_cpu(), which checks whether the
swhash is referenced. If yes it allocates a new hash and stores the pointer in
the per cpu data structure.

But at this point the cpu is still online, so there must be a valid hash
already. By overwriting the pointer the existing hash is not longer
accessible.

Remove the CPU_DOWN_FAILED state, as there is nothing to (re)allocate.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/events/core.c |    1 -
 1 file changed, 1 deletion(-)

--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9282,7 +9282,6 @@ perf_cpu_notify(struct notifier_block *s
 	switch (action & ~CPU_TASKS_FROZEN) {
 
 	case CPU_UP_PREPARE:
-	case CPU_DOWN_FAILED:
 		perf_event_init_cpu(cpu);
 		break;
 

  parent reply	other threads:[~2016-02-09 20:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 20:11 [patch 0/4] perf: Fix various cpu hotplug oddities Thomas Gleixner
2016-02-09 20:11 ` [patch 1/4] perf: Remove bogus UP_CANCELED hotplug state Thomas Gleixner
2016-02-17 12:24   ` [tip:perf/core] perf/core: " tip-bot for Thomas Gleixner
2016-02-09 20:11 ` Thomas Gleixner [this message]
2016-02-17 12:24   ` [tip:perf/core] perf/core: Remove the bogus and dangerous CPU_DOWN_FAILED " tip-bot for Thomas Gleixner
2016-02-09 20:11 ` [patch 3/4] perf: Plug potential memory leak in CPU_UP_PREPARE Thomas Gleixner
2016-02-17 12:24   ` [tip:perf/core] perf/core: " tip-bot for Thomas Gleixner
2016-02-09 20:11 ` [patch 4/4] perf: Remove unused arguments from a bunch of functions Thomas Gleixner
2016-02-17 12:25   ` [tip:perf/core] perf/core: " tip-bot for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160209201007.763417379@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.