Re: [Outreachy kernel] [PATCH v3] staging: rtl8192u: Use kmalloc_array instead of kmalloc

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Tue, Feb 09, 2016 at 10:51:21PM -0500, Janani Ravichandran wrote:
> Use kmalloc_array instead of kmalloc for arrays. The Coccinelle patch for
> this conversion is:
> 
> @@
> type T;
> expression F;
> constant FLAG;
> @@
> 
> - kmalloc(sizeof(T)*F, FLAG)
> + kmalloc_array(F, sizeof(T), FLAG)
> 
> Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
> ---
> Changes since v2:
>  * Changed the coccinelle patch in the commit description to something
>    more robust as suggested by Julia.
>  
>  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 28ad63a..fb344d1 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -601,8 +601,8 @@ static void RxReorderIndicatePacket(struct ieee80211_device *ieee,
>  	bool			bMatchWinStart = false, bPktInBuf = false;
>  	IEEE80211_DEBUG(IEEE80211_DL_REORDER,"%s(): Seq is %d,pTS->RxIndicateSeq is %d, WinSize is %d\n",__func__,SeqNum,pTS->RxIndicateSeq,WinSize);
>  
> -	prxbIndicateArray = kmalloc(sizeof(struct ieee80211_rxb *) *
> -			REORDER_WIN_SIZE, GFP_KERNEL);
> +	prxbIndicateArray = kmalloc_array(RECORDER_WIN_SIZE,

I commented on v2 as I didn't see v3 already sent.

quoting my previous mail:
"something is wrong. coccinelle should not change REORDER_WIN_SIZE to
RECORDER_WIN_SIZE.

and you did not build tested it before sending."

regards
sudip