Re: [Outreachy kernel] [PATCH] drivers: staging: lustre: lustre: lov: lov_pool: Fixed a warning

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Wed, Feb 10, 2016 at 12:24:56PM +0530, RAKHI SHARMA wrote:
> On Wed, Feb 10, 2016 at 11:44 AM, Sudip Mukherjee <
> sudipm.mukherjee@gmail.com> wrote:
> 
> > On Wed, Feb 10, 2016 at 05:28:46AM +0530, Rakhi Sharma wrote:
> > > Fixed a checkpatch warning.
> > > WARNING: struct file_operations should normally be const
> > >
> > > Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
> > > ---
> >
> > It now adds new build warning:
> >
> > ../drivers/staging/lustre/lustre/lov/lov_pool.c: In function
> > ‘lov_pool_new’:
> > ../drivers/staging/lustre/lustre/lov/lov_pool.c:438:7: warning: passing
> > argument 4 of ‘ldebugfs_add_simple’ discards ‘const’ qualifier from pointer
> > target type [enabled by default]
> >        &pool_proc_operations);
> >        ^
> > In file included from
> > ../drivers/staging/lustre/lustre/lov/../include/linux/../obd_support.h:43:0,
> >                  from
> > ../drivers/staging/lustre/lustre/lov/../include/linux/obd.h:44,
> >                  from
> > ../drivers/staging/lustre/lustre/lov/../include/obd.h:40,
> >                  from ../drivers/staging/lustre/lustre/lov/lov_pool.c:49:
> > ../drivers/staging/lustre/lustre/lov/../include/linux/../lprocfs_status.h:547:16:
> > note: expected ‘struct file_operations *’ but argument is of type ‘const
> > struct file_operations *’
> >  struct dentry *ldebugfs_add_simple(struct dentry *root,
> >
> > regards
> >
> hi Sudip,
> Will you please help me to understand why this warning produce? Is the
> const I have put there is wrong? but as I think it is ok there.may be I am
> wrong this side, please let me know how this is going on?

you should have also made it as const in the argument of
ldebugfs_add_simple() in
drivers/staging/lustre/lustre/include/lprocfs_status.h.

regards
sudip