From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 10 Feb 2016 09:05:40 +0000 Subject: [patch] staging: wilc1000: fix mgmt_tx() Message-Id: <20160210090540.GA1253@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org There was a missing curly brace so this function returns failure instead of succeeding. Fixes: 06fb9336acdc ('staging: wilc1000: wilc_wfi_cfgoperations.c: replaces PRINT_ER with netdev_err') Signed-off-by: Dan Carpenter diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index bf264d3..97d1b80 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -1832,9 +1832,10 @@ static int mgmt_tx(struct wiphy *wiphy, return -EFAULT; mgmt_tx->buff = kmalloc(buf_len, GFP_KERNEL); - if (!mgmt_tx->buff) + if (!mgmt_tx->buff) { kfree(mgmt_tx); - return -EFAULT; + return -ENOMEM; + } memcpy(mgmt_tx->buff, buf, len); mgmt_tx->size = len;