From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] adv7511: Added mode_fixup function. Date: Wed, 10 Feb 2016 13:17:47 +0100 Message-ID: <20160210121747.GS11240@phenom.ffwll.local> References: <1454063627-12219-1-git-send-email-palminha@synopsys.com> <1948106.WC7MId72vp@avalon> <56AF5176.80603@synopsys.com> <56B36CB1.80000@synopsys.com> <56B3B42C.7020804@metafoo.de> <20160209092444.GD11240@phenom.ffwll.local> <56BB0EA9.1040301@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F2576E6AE for ; Wed, 10 Feb 2016 04:17:26 -0800 (PST) Received: by mail-wm0-f51.google.com with SMTP id p63so23867716wmp.1 for ; Wed, 10 Feb 2016 04:17:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <56BB0EA9.1040301@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Carlos Palminha Cc: Laurent Pinchart , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBGZWIgMTAsIDIwMTYgYXQgMTA6MTk6MjFBTSArMDAwMCwgQ2FybG9zIFBhbG1pbmhh IHdyb3RlOgo+IEhpIGd1eXMsCj4gCj4gSSBhZ3JlZSB0aGF0IHRoaXMgc2hvdWxkIGJlIGZpeGVk IGluIHRoZSBoZWxwZXIgbGlicmFyeS4KPiBUaGVyZSBhcmUgYWxyZWFkeSBhIGxvdCBvZiBkcml2 ZXJzIHRoYXQgY29weS9wYXN0ZSBjb2RlIGFuZCBzZXZlcmFsIGhlbHBlciBmdW5jdGlvbnMgdGhh dCBkbyBub3QgYXZvaWQgaXQuCj4gCj4gSSB3aWxsIHN0YXJ0IHNlbmRpbmcgc29tZSBwYXRjaGVz IHRvIGZpeCB0aGlzIHR5cGUgb2YgaXNzdWUgaW4gc2V2ZXJhbCBwbGFjZXMgb2YgRFJNIGhlbHBl ciBmdW5jdGlvbnMuCgpBd2Vzb21lLCB0aGFua3MgYSBsb3QgZm9yIGRvaW5nIHRoaXMuCi1EYW5p ZWwKCj4gCj4gUmVnYXJkcywKPiBDLlBhbG1pbmhhCj4gCj4gT24gMDktMDItMjAxNiAwOToyNCwg RGFuaWVsIFZldHRlciB3cm90ZToKPiA+IE9uIFRodSwgRmViIDA0LCAyMDE2IGF0IDA5OjI3OjI0 UE0gKzAxMDAsIExhcnMtUGV0ZXIgQ2xhdXNlbiB3cm90ZToKPiA+PiBPbiAwMi8wNC8yMDE2IDA0 OjIyIFBNLCBDYXJsb3MgUGFsbWluaGEgd3JvdGU6Cj4gPj4+IEhpIGd1eXMsCj4gPj4+Cj4gPj4+ IGFueSBmZWVkYmFjaz8gcGF0Y2ggd2lsbCBiZSBhY2NlcHRlZCBmb3IgYWR2NzUxMSBkcml2ZXI/ Cj4gPj4KPiA+PiBIaSwKPiA+Pgo+ID4+IFRoYW5rcyBmb3IgdGhlIHBhdGNoLCBidXQgcGxlYXNl IHRyeSB0byBmaW5kIGFuZCBmaXggdGhlIGNhbGwgc2l0ZSB0aGF0IGlzCj4gPj4gdHJ5aW5nIHRv IGludm9rZSB0aGUgY2FsbGJhY2sgZXZlbiB0aG91Z2ggaXQgZG9lcyBub3QgZXhpc3QuCj4gPj4K PiA+PiBUaGlzIGlzIG1vc3QgbGlrZWx5IGRybV9pMmNfZW5jb2Rlcl9tb2RlX2ZpeHVwKCkuCj4g PiAKPiA+IEFncmVlZCwgdGhpcyBzaG91bGQgYmUgZml4ZWQgaW4gdGhlIGhlbHBlciBsaWJyYXJ5 LCBub3QgaW4gZHJpdmVycyBieQo+ID4gY29weXBhc3RpbmcgcGlsZXMgbW9yZSBkdW1teSBmdW5j dGlvbnMuCj4gPiAtRGFuaWVsCj4gPiAKPiA+Pgo+ID4+IC0gTGFycwo+ID4+Cj4gPj4+Cj4gPj4+ IFJlZ2FyZHMsCj4gPj4+IEMuUGFsbWluaGEKPiA+Pj4KPiA+Pj4gT24gMDEtMDItMjAxNiAxMjoz NywgQ2FybG9zIFBhbG1pbmhhIHdyb3RlOgo+ID4+Pj4gSGkgTGF1cmVudAo+ID4+Pj4KPiA+Pj4+ IE9uIDI5LTAxLTIwMTYgMTc6NDgsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4+Pj4gSGkg Q2FybG9zLAo+ID4+Pj4+Cj4gPj4+Pj4gVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCj4gPj4+Pj4K PiA+Pj4+PiBPbiBGcmlkYXkgMjkgSmFudWFyeSAyMDE2IDEwOjMzOjQ3IENhcmxvcyBQYWxtaW5o YSB3cm90ZToKPiA+Pj4+Pj4gVGhlIG1vZGVfZml4dXAgaXMgbmVjZXNzYXJ5IHdoZW4gdXNpbmcg aXQgaW4gYSBEUk0gRkIgZHJpdmVyIHBpcGVsaW5lLgo+ID4+Pj4+Cj4gPj4+Pj4gSW5zdGVhZCBv ZiBpbXBsZW1lbnRpbmcgc3R1YnMgaW4gZW5jb2RlciBkcml2ZXJzLCB3b3VsZG4ndCBpdCBiZSBi ZXR0ZXIgdG8gCj4gPj4+Pj4gbWFrZSBtb2RlX2ZpeHVwIG9wdGlvbmFsID8KPiA+Pj4+IFByb2Jh Ymx5IHlvdSBhcmUgcmlnaHQgYnV0IGkgZG9uJ3QgaGF2ZSBlbm91Z2gga25vd2xlZGdlIG9yIHRp bWUgdG8gZG8gdGhhdCBmb3IgdGhlIERSTSBmcmFtZXdvcmsuIDooCj4gPj4+PiBJIGxpbWl0ZWQg bXlzZWxmIHRvIGRvIHdoYXQgdGhlIG90aGVyIGRyaXZlcnMgYWxyZWFkeSBpbXBsZW1lbnQuCj4g Pj4+Pgo+ID4+Pj4gVGhlIHBhdGNoIGlzIG1hbmRhdG9yeSB0byBoYXZlIHRvIHRoZSBBRFYgd29y a2luZyBvciBlbHNlIHdpbGwgZ2V0IHNvbWUgTlVMTCBwb2ludGVyIGNyYXNoLgo+ID4+Pj4KPiA+ Pj4+IFJlZ2FyZHMsCj4gPj4+PiBDLlBhbG1pbmhhCj4gPj4+Pgo+ID4+Pj4+Cj4gPj4+Pj4+IFNp Z25lZC1vZmYtYnk6IENhcmxvcyBQYWxtaW5oYSA8cGFsbWluaGFAc3lub3BzeXMuY29tPgo+ID4+ Pj4+PiAtLS0KPiA+Pj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMS5jIHwgOCArKysr KysrKwo+ID4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKQo+ID4+Pj4+Pgo+ ID4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2kyYy9hZHY3NTExLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTJjL2Fkdjc1MTEuYwo+ID4+Pj4+PiBpbmRleCA1MzNkMWUzLi45MDA4MmQy IDEwMDY0NAo+ID4+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTJjL2Fkdjc1MTEuYwo+ID4+ Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTJjL2Fkdjc1MTEuYwo+ID4+Pj4+PiBAQCAtNjQ4 LDYgKzY0OCwxMyBAQCBhZHY3NTExX2VuY29kZXJfZGV0ZWN0KHN0cnVjdCBkcm1fZW5jb2RlciAq ZW5jb2RlciwKPiA+Pj4+Pj4gIAlyZXR1cm4gc3RhdHVzOwo+ID4+Pj4+PiAgfQo+ID4+Pj4+Pgo+ ID4+Pj4+PiArc3RhdGljIGJvb2wgYWR2NzUxMV9lbmNvZGVyX21vZGVfZml4dXAoc3RydWN0IGRy bV9lbmNvZGVyICplbmNvZGVyLAo+ID4+Pj4+PiArCQkJCQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3Bs YXlfbW9kZSAqbW9kZSwKPiA+Pj4+Pj4gKwkJCQkJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmFk anVzdGVkX21vZGUpCj4gPj4+Pj4+ICt7Cj4gPj4+Pj4+ICsJcmV0dXJuIHRydWU7Cj4gPj4+Pj4+ ICt9Cj4gPj4+Pj4+ICsKPiA+Pj4+Pj4gIHN0YXRpYyBpbnQgYWR2NzUxMV9lbmNvZGVyX21vZGVf dmFsaWQoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ID4+Pj4+PiAgCQkJCSAgICAgIHN0 cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlKQo+ID4+Pj4+PiAgewo+ID4+Pj4+PiBAQCAtNzU0 LDYgKzc2MSw3IEBAIHN0YXRpYyB2b2lkIGFkdjc1MTFfZW5jb2Rlcl9tb2RlX3NldChzdHJ1Y3Qg ZHJtX2VuY29kZXIKPiA+Pj4+Pj4gKmVuY29kZXIsCj4gPj4+Pj4+Cj4gPj4+Pj4+ICBzdGF0aWMg Y29uc3Qgc3RydWN0IGRybV9lbmNvZGVyX3NsYXZlX2Z1bmNzIGFkdjc1MTFfZW5jb2Rlcl9mdW5j cyA9IHsKPiA+Pj4+Pj4gIAkuZHBtcyA9IGFkdjc1MTFfZW5jb2Rlcl9kcG1zLAo+ID4+Pj4+PiAr CS5tb2RlX2ZpeHVwID0gYWR2NzUxMV9lbmNvZGVyX21vZGVfZml4dXAsCj4gPj4+Pj4+ICAJLm1v ZGVfdmFsaWQgPSBhZHY3NTExX2VuY29kZXJfbW9kZV92YWxpZCwKPiA+Pj4+Pj4gIAkubW9kZV9z ZXQgPSBhZHY3NTExX2VuY29kZXJfbW9kZV9zZXQsCj4gPj4+Pj4+ICAJLmRldGVjdCA9IGFkdjc1 MTFfZW5jb2Rlcl9kZXRlY3QsCj4gPj4+Pj4KPiA+Pj4+Cj4gPj4+Pgo+ID4+Pj4gT24gMjktMDEt MjAxNiAxNzo0OCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4+PiBIaSBDYXJsb3MsCj4g Pj4+Pj4KPiA+Pj4+PiBUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KPiA+Pj4+Pgo+ID4+Pj4+IE9u IEZyaWRheSAyOSBKYW51YXJ5IDIwMTYgMTA6MzM6NDcgQ2FybG9zIFBhbG1pbmhhIHdyb3RlOgo+ ID4+Pj4+PiBUaGUgbW9kZV9maXh1cCBpcyBuZWNlc3Nhcnkgd2hlbiB1c2luZyBpdCBpbiBhIERS TSBGQiBkcml2ZXIgcGlwZWxpbmUuCj4gPj4+Pj4KPiA+Pj4+PiBJbnN0ZWFkIG9mIGltcGxlbWVu dGluZyBzdHVicyBpbiBlbmNvZGVyIGRyaXZlcnMsIHdvdWxkbid0IGl0IGJlIGJldHRlciB0byAK PiA+Pj4+PiBtYWtlIG1vZGVfZml4dXAgb3B0aW9uYWwgPwo+ID4+Pj4+Cj4gPj4+Pj4+IFNpZ25l ZC1vZmYtYnk6IENhcmxvcyBQYWxtaW5oYSA8cGFsbWluaGFAc3lub3BzeXMuY29tPgo+ID4+Pj4+ PiAtLS0KPiA+Pj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMS5jIHwgOCArKysrKysr Kwo+ID4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKQo+ID4+Pj4+Pgo+ID4+ Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2kyYy9hZHY3NTExLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTJjL2Fkdjc1MTEuYwo+ID4+Pj4+PiBpbmRleCA1MzNkMWUzLi45MDA4MmQyIDEw MDY0NAo+ID4+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTJjL2Fkdjc1MTEuYwo+ID4+Pj4+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTJjL2Fkdjc1MTEuYwo+ID4+Pj4+PiBAQCAtNjQ4LDYg KzY0OCwxMyBAQCBhZHY3NTExX2VuY29kZXJfZGV0ZWN0KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5j b2RlciwKPiA+Pj4+Pj4gIAlyZXR1cm4gc3RhdHVzOwo+ID4+Pj4+PiAgfQo+ID4+Pj4+Pgo+ID4+ Pj4+PiArc3RhdGljIGJvb2wgYWR2NzUxMV9lbmNvZGVyX21vZGVfZml4dXAoc3RydWN0IGRybV9l bmNvZGVyICplbmNvZGVyLAo+ID4+Pj4+PiArCQkJCQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlf bW9kZSAqbW9kZSwKPiA+Pj4+Pj4gKwkJCQkJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmFkanVz dGVkX21vZGUpCj4gPj4+Pj4+ICt7Cj4gPj4+Pj4+ICsJcmV0dXJuIHRydWU7Cj4gPj4+Pj4+ICt9 Cj4gPj4+Pj4+ICsKPiA+Pj4+Pj4gIHN0YXRpYyBpbnQgYWR2NzUxMV9lbmNvZGVyX21vZGVfdmFs aWQoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ID4+Pj4+PiAgCQkJCSAgICAgIHN0cnVj dCBkcm1fZGlzcGxheV9tb2RlICptb2RlKQo+ID4+Pj4+PiAgewo+ID4+Pj4+PiBAQCAtNzU0LDYg Kzc2MSw3IEBAIHN0YXRpYyB2b2lkIGFkdjc1MTFfZW5jb2Rlcl9tb2RlX3NldChzdHJ1Y3QgZHJt X2VuY29kZXIKPiA+Pj4+Pj4gKmVuY29kZXIsCj4gPj4+Pj4+Cj4gPj4+Pj4+ICBzdGF0aWMgY29u c3Qgc3RydWN0IGRybV9lbmNvZGVyX3NsYXZlX2Z1bmNzIGFkdjc1MTFfZW5jb2Rlcl9mdW5jcyA9 IHsKPiA+Pj4+Pj4gIAkuZHBtcyA9IGFkdjc1MTFfZW5jb2Rlcl9kcG1zLAo+ID4+Pj4+PiArCS5t b2RlX2ZpeHVwID0gYWR2NzUxMV9lbmNvZGVyX21vZGVfZml4dXAsCj4gPj4+Pj4+ICAJLm1vZGVf dmFsaWQgPSBhZHY3NTExX2VuY29kZXJfbW9kZV92YWxpZCwKPiA+Pj4+Pj4gIAkubW9kZV9zZXQg PSBhZHY3NTExX2VuY29kZXJfbW9kZV9zZXQsCj4gPj4+Pj4+ICAJLmRldGVjdCA9IGFkdjc1MTFf ZW5jb2Rlcl9kZXRlY3QsCj4gPj4+Pj4KPiA+Pj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiA+Pj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ID4+PiBk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPj4+IGh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiA+Pj4KPiA+Pgo+ID4+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPj4gZHJpLWRldmVs IG1haWxpbmcgbGlzdAo+ID4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+PiBo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4g PiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpo dHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750894AbcBJMR1 (ORCPT ); Wed, 10 Feb 2016 07:17:27 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37608 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbcBJMRZ (ORCPT ); Wed, 10 Feb 2016 07:17:25 -0500 Date: Wed, 10 Feb 2016 13:17:47 +0100 From: Daniel Vetter To: Carlos Palminha Cc: Lars-Peter Clausen , Laurent Pinchart , David Airlie , Laurent Pinchart , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] adv7511: Added mode_fixup function. Message-ID: <20160210121747.GS11240@phenom.ffwll.local> Mail-Followup-To: Carlos Palminha , Lars-Peter Clausen , Laurent Pinchart , David Airlie , Laurent Pinchart , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1454063627-12219-1-git-send-email-palminha@synopsys.com> <1948106.WC7MId72vp@avalon> <56AF5176.80603@synopsys.com> <56B36CB1.80000@synopsys.com> <56B3B42C.7020804@metafoo.de> <20160209092444.GD11240@phenom.ffwll.local> <56BB0EA9.1040301@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56BB0EA9.1040301@synopsys.com> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2016 at 10:19:21AM +0000, Carlos Palminha wrote: > Hi guys, > > I agree that this should be fixed in the helper library. > There are already a lot of drivers that copy/paste code and several helper functions that do not avoid it. > > I will start sending some patches to fix this type of issue in several places of DRM helper functions. Awesome, thanks a lot for doing this. -Daniel > > Regards, > C.Palminha > > On 09-02-2016 09:24, Daniel Vetter wrote: > > On Thu, Feb 04, 2016 at 09:27:24PM +0100, Lars-Peter Clausen wrote: > >> On 02/04/2016 04:22 PM, Carlos Palminha wrote: > >>> Hi guys, > >>> > >>> any feedback? patch will be accepted for adv7511 driver? > >> > >> Hi, > >> > >> Thanks for the patch, but please try to find and fix the call site that is > >> trying to invoke the callback even though it does not exist. > >> > >> This is most likely drm_i2c_encoder_mode_fixup(). > > > > Agreed, this should be fixed in the helper library, not in drivers by > > copypasting piles more dummy functions. > > -Daniel > > > >> > >> - Lars > >> > >>> > >>> Regards, > >>> C.Palminha > >>> > >>> On 01-02-2016 12:37, Carlos Palminha wrote: > >>>> Hi Laurent > >>>> > >>>> On 29-01-2016 17:48, Laurent Pinchart wrote: > >>>>> Hi Carlos, > >>>>> > >>>>> Thank you for the patch. > >>>>> > >>>>> On Friday 29 January 2016 10:33:47 Carlos Palminha wrote: > >>>>>> The mode_fixup is necessary when using it in a DRM FB driver pipeline. > >>>>> > >>>>> Instead of implementing stubs in encoder drivers, wouldn't it be better to > >>>>> make mode_fixup optional ? > >>>> Probably you are right but i don't have enough knowledge or time to do that for the DRM framework. :( > >>>> I limited myself to do what the other drivers already implement. > >>>> > >>>> The patch is mandatory to have to the ADV working or else will get some NULL pointer crash. > >>>> > >>>> Regards, > >>>> C.Palminha > >>>> > >>>>> > >>>>>> Signed-off-by: Carlos Palminha > >>>>>> --- > >>>>>> drivers/gpu/drm/i2c/adv7511.c | 8 ++++++++ > >>>>>> 1 file changed, 8 insertions(+) > >>>>>> > >>>>>> diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c > >>>>>> index 533d1e3..90082d2 100644 > >>>>>> --- a/drivers/gpu/drm/i2c/adv7511.c > >>>>>> +++ b/drivers/gpu/drm/i2c/adv7511.c > >>>>>> @@ -648,6 +648,13 @@ adv7511_encoder_detect(struct drm_encoder *encoder, > >>>>>> return status; > >>>>>> } > >>>>>> > >>>>>> +static bool adv7511_encoder_mode_fixup(struct drm_encoder *encoder, > >>>>>> + const struct drm_display_mode *mode, > >>>>>> + struct drm_display_mode *adjusted_mode) > >>>>>> +{ > >>>>>> + return true; > >>>>>> +} > >>>>>> + > >>>>>> static int adv7511_encoder_mode_valid(struct drm_encoder *encoder, > >>>>>> struct drm_display_mode *mode) > >>>>>> { > >>>>>> @@ -754,6 +761,7 @@ static void adv7511_encoder_mode_set(struct drm_encoder > >>>>>> *encoder, > >>>>>> > >>>>>> static const struct drm_encoder_slave_funcs adv7511_encoder_funcs = { > >>>>>> .dpms = adv7511_encoder_dpms, > >>>>>> + .mode_fixup = adv7511_encoder_mode_fixup, > >>>>>> .mode_valid = adv7511_encoder_mode_valid, > >>>>>> .mode_set = adv7511_encoder_mode_set, > >>>>>> .detect = adv7511_encoder_detect, > >>>>> > >>>> > >>>> > >>>> On 29-01-2016 17:48, Laurent Pinchart wrote: > >>>>> Hi Carlos, > >>>>> > >>>>> Thank you for the patch. > >>>>> > >>>>> On Friday 29 January 2016 10:33:47 Carlos Palminha wrote: > >>>>>> The mode_fixup is necessary when using it in a DRM FB driver pipeline. > >>>>> > >>>>> Instead of implementing stubs in encoder drivers, wouldn't it be better to > >>>>> make mode_fixup optional ? > >>>>> > >>>>>> Signed-off-by: Carlos Palminha > >>>>>> --- > >>>>>> drivers/gpu/drm/i2c/adv7511.c | 8 ++++++++ > >>>>>> 1 file changed, 8 insertions(+) > >>>>>> > >>>>>> diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c > >>>>>> index 533d1e3..90082d2 100644 > >>>>>> --- a/drivers/gpu/drm/i2c/adv7511.c > >>>>>> +++ b/drivers/gpu/drm/i2c/adv7511.c > >>>>>> @@ -648,6 +648,13 @@ adv7511_encoder_detect(struct drm_encoder *encoder, > >>>>>> return status; > >>>>>> } > >>>>>> > >>>>>> +static bool adv7511_encoder_mode_fixup(struct drm_encoder *encoder, > >>>>>> + const struct drm_display_mode *mode, > >>>>>> + struct drm_display_mode *adjusted_mode) > >>>>>> +{ > >>>>>> + return true; > >>>>>> +} > >>>>>> + > >>>>>> static int adv7511_encoder_mode_valid(struct drm_encoder *encoder, > >>>>>> struct drm_display_mode *mode) > >>>>>> { > >>>>>> @@ -754,6 +761,7 @@ static void adv7511_encoder_mode_set(struct drm_encoder > >>>>>> *encoder, > >>>>>> > >>>>>> static const struct drm_encoder_slave_funcs adv7511_encoder_funcs = { > >>>>>> .dpms = adv7511_encoder_dpms, > >>>>>> + .mode_fixup = adv7511_encoder_mode_fixup, > >>>>>> .mode_valid = adv7511_encoder_mode_valid, > >>>>>> .mode_set = adv7511_encoder_mode_set, > >>>>>> .detect = adv7511_encoder_detect, > >>>>> > >>> _______________________________________________ > >>> dri-devel mailing list > >>> dri-devel@lists.freedesktop.org > >>> http://lists.freedesktop.org/mailman/listinfo/dri-devel > >>> > >> > >> _______________________________________________ > >> dri-devel mailing list > >> dri-devel@lists.freedesktop.org > >> http://lists.freedesktop.org/mailman/listinfo/dri-devel > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch