From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: efi: make most efivarfs files immutable by default Date: Wed, 10 Feb 2016 13:22:25 +0000 Message-ID: <20160210132225.GA2949@codeblueprint.co.uk> References: <20160204234211.GI2586@codeblueprint.co.uk> <1454960895-3473-1-git-send-email-pjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1454960895-3473-1-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Jones Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-efi@vger.kernel.org On Mon, 08 Feb, at 02:48:10PM, Peter Jones wrote: > Hi, > Here's the latest version of my patch series to make efivarfs make files > be immutable by default unless they're on our whitelist. As you might > expect, this version has a couple of differences from the previous one: > > In patch 2/5: > - efivar_create_sysfs_entry() was reworked to use the length it computes > instead of lots of calls to strlen(), and it doesn't have unused > variables any more. > In 3/5: > - "len" was renamed to "data_size" for clarity, and we calculate the > variable name's size correctly instead now. > In 4/5: > - The commit message was reworded based largely on mfleming's suggestions. > In 5/5: > - An old comment from a previous version was fixed to not be confusing. > - the inode lock is now taken when we're modifying inode metadata. Thanks Peter. I've applied all of these patches to the EFI 'urgent' branch. I've got a little more testing to do, but assuming it all goes OK I'll send a pull request to tip this Friday. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com ([74.125.82.53]:33256 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbcBJNW2 (ORCPT ); Wed, 10 Feb 2016 08:22:28 -0500 Received: by mail-wm0-f53.google.com with SMTP id g62so26774600wme.0 for ; Wed, 10 Feb 2016 05:22:27 -0800 (PST) Date: Wed, 10 Feb 2016 13:22:25 +0000 From: Matt Fleming To: Peter Jones Cc: linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: efi: make most efivarfs files immutable by default Message-ID: <20160210132225.GA2949@codeblueprint.co.uk> References: <20160204234211.GI2586@codeblueprint.co.uk> <1454960895-3473-1-git-send-email-pjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454960895-3473-1-git-send-email-pjones@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 08 Feb, at 02:48:10PM, Peter Jones wrote: > Hi, > Here's the latest version of my patch series to make efivarfs make files > be immutable by default unless they're on our whitelist. As you might > expect, this version has a couple of differences from the previous one: > > In patch 2/5: > - efivar_create_sysfs_entry() was reworked to use the length it computes > instead of lots of calls to strlen(), and it doesn't have unused > variables any more. > In 3/5: > - "len" was renamed to "data_size" for clarity, and we calculate the > variable name's size correctly instead now. > In 4/5: > - The commit message was reworded based largely on mfleming's suggestions. > In 5/5: > - An old comment from a previous version was fixed to not be confusing. > - the inode lock is now taken when we're modifying inode metadata. Thanks Peter. I've applied all of these patches to the EFI 'urgent' branch. I've got a little more testing to do, but assuming it all goes OK I'll send a pull request to tip this Friday.