From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com. [2a00:1450:400c:c09::236]) by gmr-mx.google.com with ESMTPS id w197si146047wmw.3.2016.02.10.08.09.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Feb 2016 08:09:16 -0800 (PST) Received: by mail-wm0-x236.google.com with SMTP id c200so34857069wme.0 for ; Wed, 10 Feb 2016 08:09:16 -0800 (PST) Date: Wed, 10 Feb 2016 16:09:12 +0000 From: Lee Jones To: Laxman Dewangan Cc: alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com, javier@osg.samsung.com, broonie@kernel.org, gregkh@linuxfoundation.org, a.zummo@towertech.it, cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: [rtc-linux] Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Message-ID: <20160210160912.GF26950@x1> References: <1455038794-9921-1-git-send-email-ldewangan@nvidia.com> <1455038794-9921-5-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1455038794-9921-5-git-send-email-ldewangan@nvidia.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tue, 09 Feb 2016, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. >=20 > As there is no call to i2c_get_clientdata() for rtc_i2c client, > there is no need to store pointer and hence removing the call > to set client data for rtc i2c client. >=20 > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > Tested-by: Javier Martinez Canillas > Reviewed-by: Javier Martinez Canillas >=20 > --- > This is new in this series based on review comment from V1. >=20 > Changes from V2: > - Rephrase description. > - Added reviewed by. >=20 > Changes from V3: > - None, become 5th on series. >=20 > Changes from V4: > None >=20 > Changes from V5: > None >=20 > Changes from V6: > Make this as 4th of series as regmap change applied independently. >=20 > drivers/mfd/max77686.c | 1 - > 1 file changed, 1 deletion(-) Appart from the subject line being wrong: Acked-by: Lee Jones [...] --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752614AbcBJQJT (ORCPT ); Wed, 10 Feb 2016 11:09:19 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38134 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbcBJQJR (ORCPT ); Wed, 10 Feb 2016 11:09:17 -0500 Date: Wed, 10 Feb 2016 16:09:12 +0000 From: Lee Jones To: Laxman Dewangan Cc: alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com, javier@osg.samsung.com, broonie@kernel.org, gregkh@linuxfoundation.org, a.zummo@towertech.it, cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Message-ID: <20160210160912.GF26950@x1> References: <1455038794-9921-1-git-send-email-ldewangan@nvidia.com> <1455038794-9921-5-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455038794-9921-5-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Feb 2016, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no call to i2c_get_clientdata() for rtc_i2c client, > there is no need to store pointer and hence removing the call > to set client data for rtc i2c client. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > Tested-by: Javier Martinez Canillas > Reviewed-by: Javier Martinez Canillas > > --- > This is new in this series based on review comment from V1. > > Changes from V2: > - Rephrase description. > - Added reviewed by. > > Changes from V3: > - None, become 5th on series. > > Changes from V4: > None > > Changes from V5: > None > > Changes from V6: > Make this as 4th of series as regmap change applied independently. > > drivers/mfd/max77686.c | 1 - > 1 file changed, 1 deletion(-) Appart from the subject line being wrong: Acked-by: Lee Jones [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog