From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752651AbcBJQxQ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Feb 2016 11:53:16 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:57768 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750757AbcBJQxP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Feb 2016 11:53:15 -0500
Date: Wed, 10 Feb 2016 08:53:14 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: Christian Brauner <christian.brauner@mailbox.org>
Cc: tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] let kernfs_name_locked & kernfs_name return size_t
Message-ID: <20160210165314.GA27721@kroah.com>
References: <1455121139-4026-1-git-send-email-christian.brauner@mailbox.org>
 <1455121139-4026-2-git-send-email-christian.brauner@mailbox.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1455121139-4026-2-git-send-email-christian.brauner@mailbox.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 10, 2016 at 05:18:59PM +0100, Christian Brauner wrote:
> They return the length of kn->parent or kn->name and should be aligned with
> kernfs_path_len which also returns size_t.
> 
> Signed-off-by: Christian Brauner <christian.brauner@mailbox.org>
> ---
>  fs/kernfs/dir.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
> index 742bf4a..a3553b8 100644
> --- a/fs/kernfs/dir.c
> +++ b/fs/kernfs/dir.c
> @@ -39,7 +39,7 @@ static bool kernfs_lockdep(struct kernfs_node *kn)
>  #endif
>  }
>  
> -static int kernfs_name_locked(struct kernfs_node *kn, char *buf, size_t buflen)
> +static size_t kernfs_name_locked(struct kernfs_node *kn, char *buf, size_t buflen)
>  {
>  	return strlcpy(buf, kn->parent ? kn->name : "/", buflen);
>  }
> @@ -80,7 +80,7 @@ static char * __must_check kernfs_path_locked(struct kernfs_node *kn, char *buf,
>   *
>   * This function can be called from any context.
>   */
> -int kernfs_name(struct kernfs_node *kn, char *buf, size_t buflen)
> +size_t kernfs_name(struct kernfs_node *kn, char *buf, size_t buflen)
>  {
>  	unsigned long flags;
>  	int ret;

Now if only you had test built this patch :(

Please be more careful, it just makes maintainers grumpy and annoyed
when you do that...