From: Stephen Hemminger <stephen@networkplumber.org>
To: Vincent JARDIN <vincent.jardin@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] virtio: prettify log messages
Date: Wed, 10 Feb 2016 17:12:36 -0800 [thread overview]
Message-ID: <20160210171236.77aa24dc@xeon-e3> (raw)
In-Reply-To: <1455147934-15060-1-git-send-email-vincent.jardin@6wind.com>
On Thu, 11 Feb 2016 00:45:34 +0100
Vincent JARDIN <vincent.jardin@6wind.com> wrote:
> PMD_TX_LOG() looks better with a \n
>
> Signed-off-by: Vincent JARDIN <vincent.jardin@6wind.com>
NAK. Yes the messages, are messed up, but this is not
the right way to fix it.
The logging wrappers are inconsistent in virtio.
PMD_INIT_LOG adds newline, but RX/TX/DRV do not.
I would rather the macros were aligned with ixgbe which always
adds newline for all the PMD_XXX_LOG() macros. And then remove
all extra newlines in virtio code.
next prev parent reply other threads:[~2016-02-11 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 23:45 [PATCH] virtio: prettify log messages Vincent JARDIN
2016-02-11 1:12 ` Stephen Hemminger [this message]
2016-02-11 6:45 ` Vincent JARDIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210171236.77aa24dc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=vincent.jardin@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.