From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Subject: Does _need_to_be_root deserve to live?
Date: Wed, 10 Feb 2016 22:57:46 -0500 [thread overview]
Message-ID: <20160211035746.GA16082@thunk.org> (raw)
There appear to be a number of tests that need to mount and unmount
scratch or su to $qa_user that don't call the helper _need_to_be_root.
Also, sicne the check script calls _check_filesystems between every
single test, which requires unmounting and remounting the test and/or
scratch file systems, does the _need_to_be_root check make any sense
at all?
And if doesn't make any sense, is it worth it to submitting a patch
that just removes all mention of _need_to_be_root from the tests and
common/rc?
Cheers,
- Ted
next reply other threads:[~2016-02-11 3:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 3:57 Theodore Ts'o [this message]
2016-02-11 9:15 ` Does _need_to_be_root deserve to live? Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211035746.GA16082@thunk.org \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.