From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 11 Feb 2016 16:30:14 +0100 (CET) Received: from localhost.localdomain ([127.0.0.1]:36170 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27011283AbcBKPaNO4rpN (ORCPT ); Thu, 11 Feb 2016 16:30:13 +0100 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.15.2/8.14.8) with ESMTP id u1BFUBDV008645; Thu, 11 Feb 2016 16:30:11 +0100 Received: (from ralf@localhost) by scotty.linux-mips.net (8.15.2/8.15.2/Submit) id u1BFU9jE008644; Thu, 11 Feb 2016 16:30:09 +0100 Date: Thu, 11 Feb 2016 16:30:09 +0100 From: Ralf Baechle To: "Maciej W. Rozycki" Cc: Daniel Wagner , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH v4 2/2] mips: Differentiate between 32 and 64 bit ELF header Message-ID: <20160211153009.GG11091@linux-mips.org> References: <56BAD881.9000208@bmw-carit.de> <1455096081-7176-1-git-send-email-daniel.wagner@bmw-carit.de> <1455096081-7176-3-git-send-email-daniel.wagner@bmw-carit.de> <20160211104903.GD11091@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 52009 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Thu, Feb 11, 2016 at 02:58:55PM +0000, Maciej W. Rozycki wrote: > Date: Thu, 11 Feb 2016 14:58:55 +0000 > From: "Maciej W. Rozycki" > To: Ralf Baechle > CC: Daniel Wagner , > linux-kernel@vger.kernel.org, linux-mips@linux-mips.org > Subject: Re: [PATCH v4 2/2] mips: Differentiate between 32 and 64 bit ELF > header > Content-Type: text/plain; charset="ISO-8859-7" > > On Thu, 11 Feb 2016, Maciej W. Rozycki wrote: > > > > > Signed-off-by: Daniel Wagner > > > > Suggested-by: Maciej W. Rozycki > > > > Reviewed-by: Maciej W. Rozycki > > > > Reported-by: Fengguang Wu > > > > > > Thanks, applied. > > > > > > I'm getting a less spectacular warning from gcc 5.2: > > > > > > CC fs/proc/vmcore.o > > > fs/proc/vmcore.c: In function ‘parse_crash_elf64_headers’: > > > fs/proc/vmcore.c:939:47: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] > > > > Yes, the temporaries still need to have their pointed types changed, to > > `Elf32_Ehdr' and `Elf64_Ehdr' respectively, as in the original change. > > > > I had it mentioned in a WIP version of my review (stating that it would > > verify that the correct type is used by the caller), but then deleted that > > part inadvertently, sigh. > > Hold on, I was right in dropping it actually. > > With your v4 change in place all `parse_crash_elf64_headers' is supposed > to call is `mips_elf_check_machine' and that doesn't make any > intialisations, it just dereferences the pointer passed once. This error > does not make any sense to me and line 939 isn't even in > `parse_crash_elf64_headers', which starts at line 999, it's in > `process_ptload_program_headers_elf32'. > > So Ralf, what tree are you using that is off from LMO/Linus by 60 lines? That was 3.16, the oldest version affected. But I'm getting the same messages with different line numbers on more recent kernels including the master branch. Ralf