All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy TARREAU <wtarreau@haproxy.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de,
	linux-kernel@vger.kernel.org,
	Daniel Chromik <daniel.chromik@seznam.cz>,
	Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Subject: Re: [PATCH] misc: panel, convert struct to bitmap
Date: Thu, 11 Feb 2016 18:12:37 +0100	[thread overview]
Message-ID: <20160211171237.GP25328@haproxy.com> (raw)
In-Reply-To: <1455193763-14258-1-git-send-email-jslaby@suse.cz>

On Thu, Feb 11, 2016 at 01:29:23PM +0100, Jiri Slaby wrote:
> From: Daniel Chromik <daniel.chromik@seznam.cz>
> 
> There is an anonymous struct which is actually used as a bitmap. So
> convert the struct to a bitmap and change code accordingly where
> needed.
> 
> This also allows for a cleanup of set_data_bits and set_ctrl_bits as
> they can use a common helper now. The helper can also be converted to
> a for loop instead of doing bit OR. And given it is a for loop now,
> bit masking (using BIT_MSK) is moved from the callers there too.
> 
> Signed-off-by: Daniel Chromik <daniel.chromik@seznam.cz>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Willy Tarreau <willy@haproxy.com>
> Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>

Acked-by: Willy Tarreau <willy@haproxy.com>

Thanks,
Willy

      reply	other threads:[~2016-02-11 17:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 12:29 [PATCH] misc: panel, convert struct to bitmap Jiri Slaby
2016-02-11 17:12 ` Willy TARREAU [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160211171237.GP25328@haproxy.com \
    --to=wtarreau@haproxy.com \
    --cc=arnd@arndb.de \
    --cc=daniel.chromik@seznam.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.