All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] valgrind: fix musl compile
Date: Thu, 11 Feb 2016 21:18:45 +0100	[thread overview]
Message-ID: <20160211211845.5e9954f9@gmx.net> (raw)
In-Reply-To: <56BA75AA.20403@mind.be>

Hello Arnout,

On Wed, 10 Feb 2016 00:26:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote:

> On 09-02-16 23:53, Peter Seiderer wrote:
> > Add musl libc detection (based on suggestions by Romain Naour and
> > Arnout Vandecappelle) and add some tweaks for musl support (based
> > on OpenWRT patch [1]).
> > 
> > Fixes ([2]):
> >   checking the glibc version... unsupported version
> >   configure: error: Valgrind requires glibc version 2.2 or later
> > 
> > Patch suggested upstream (see [3]).
> > 
> > [1] https://dev.openwrt.org/browser/trunk/package/devel/valgrind/patches/200-musl_fix.patch?rev=46302
> > [2] http://autobuild.buildroot.org/results/7b0/7b048ba58918f0a08498c61327fcf35a85a84837
> > [3] https://bugs.kde.org/show_bug.cgi?id=359202
> > 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> 
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> 
>  One small nit:
> 
> [snip]
> > + 	AC_MSG_RESULT([unsupported version ${GLIBC_VERSION}])
> > +-	AC_MSG_ERROR([Valgrind requires glibc version 2.2 or later,])
> > +-	AC_MSG_ERROR([Darwin libc, Bionic libc or Solaris libc])
> > ++	AC_MSG_ERROR([Valgrind requires glibc version 2.2 or later, uclibc,])
> 
>  It's uClibc (capital C).

O.k, fixed it (and many thanks for review patience)...

> 
> > ++	AC_MSG_ERROR([musl libc, Darwin libc, Bionic libc or Solaris libc])
> > + 	;;
> > + esac
> > + 
> [snip]
> 
>  I guess you'll update the upstream bug report as well?
>

Yes, done now...

Regards,
Peter
 
>  Regards,
>  Arnout
> 
> 

      reply	other threads:[~2016-02-11 20:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 22:53 [Buildroot] [PATCH v3] valgrind: fix musl compile Peter Seiderer
2016-02-09 23:26 ` Arnout Vandecappelle
2016-02-11 20:18   ` Peter Seiderer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160211211845.5e9954f9@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.