From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751600AbcBLDSJ (ORCPT ); Thu, 11 Feb 2016 22:18:09 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38791 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbcBLDSI (ORCPT ); Thu, 11 Feb 2016 22:18:08 -0500 Date: Thu, 11 Feb 2016 19:18:07 -0800 From: Greg KH To: Christian Brauner Cc: tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] let kernfs_name_locked & kernfs_name return size_t Message-ID: <20160212031807.GC10157@kroah.com> References: <1455131226-6836-1-git-send-email-christian.brauner@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455131226-6836-1-git-send-email-christian.brauner@mailbox.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2016 at 08:07:05PM +0100, Christian Brauner wrote: > Simple patch that changes the return value of kernfs_name_locked and kernfs_name > to size_t which alignes these functions with kernfs_path_len which also returns > size_t. > > Patch was made against for-4.5 branch of Tejun's cgroup tree. (As per Tejun's > request, ccing gregkh@linuxfoundation.org and linux-kernel@vger.kernel.org.) > > Changelog > 20150210: - Change return type of kernfs_name in kernfs.h as well. > - Build tested against Tejun's for-4.5 tree, 4.5-rc2 and > mainline 4.5-rc3. > > *Note*, the changes in kernfs.h change the dummy return value of the static > inline definition of kernfs_name from -ENOSYS. I changed it to 0 analogous to > kernfs_path_len. I don't know if this is considered a deal-breaker. Please don't change that, that's a behavior change, not just a "cleanup the return type" change. thanks, greg k-h