Re: [Outreachy kernel] [PATCH] Staging: xgifb: Use shorthand operator

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Feb 09, 2016 at 09:25:33PM +0530, Bhumika Goyal wrote:
> Use shorthand operator for assignment statement to make code look cleaner.
> Made a coccinelle script for this and did changes.
> @@
> identifier data;
> constant x;
> @@
> 
> (
> - data = data + x
> + data += x
> |
> - data = data - x
> + data -= x
> )
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/staging/xgifb/vb_setmode.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index de96da1..0daa661 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -289,7 +289,7 @@ static void XGI_SetCRT1Timing_H(struct vb_device_info *pVBInfo,
>  
>  	if (HwDeviceExtension->jChipType >= XG20) {
>  		data = xgifb_reg_get(pVBInfo->P3d4, 0x04);
> -		data = data - 1;
> +		data -= 1;

Sorry, I'm not going to take these kinds of "cleanups" anymore, they
aren't doing much...

greg k-h