From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbcBLEDS (ORCPT ); Thu, 11 Feb 2016 23:03:18 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42477 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbcBLEDR (ORCPT ); Thu, 11 Feb 2016 23:03:17 -0500 Date: Thu, 11 Feb 2016 20:03:16 -0800 From: Greg Kroah-Hartman To: Colin Vidal Cc: "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH v2] Staging: fix coding style in rtl8188eu/core Message-ID: <20160212040316.GA6947@kroah.com> References: <1455138571-12956-1-git-send-email-colin@cvidal.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455138571-12956-1-git-send-email-colin@cvidal.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2016 at 10:09:28PM +0100, Colin Vidal wrote: > Set constant operand on right of test, and refactor the code in a more > compact and readable way. Please don't do two different things in the same patch, break this up into different patches. thanks, gregk -h