From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.cz>, Dmitry Vyukov <dvyukov@google.com>,
linux-ext4@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix scheduling in atomic on group checksum failure
Date: Thu, 11 Feb 2016 23:47:19 -0500 [thread overview]
Message-ID: <20160212044719.GC11298@thunk.org> (raw)
In-Reply-To: <20160210175246.GA6338@birch.djwong.org>
On Wed, Feb 10, 2016 at 09:52:46AM -0800, Darrick J. Wong wrote:
> On Wed, Feb 10, 2016 at 02:58:30PM +0100, Jan Kara wrote:
> > When block group checksum is wrong, we call ext4_error() while holding
> > group spinlock from ext4_init_block_bitmap() or
> > ext4_init_inode_bitmap() which results in scheduling while in atomic.
> > Fix the issue by calling ext4_error() later after dropping the spinlock.
> >
> > CC: stable@vger.kernel.org
> > Reported-by: Dmitry Vyukov <dvyukov@google.com>
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> Looks ok, so
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2016-02-12 4:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 13:58 [PATCH] ext4: Fix scheduling in atomic on group checksum failure Jan Kara
2016-02-10 17:52 ` Darrick J. Wong
2016-02-12 4:47 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212044719.GC11298@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=dvyukov@google.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.