All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: lasse.collin@tukaani.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, alain@knaff.lu,
	albin.tonnerre@free-electrons.com, phillip@lougher.demon.co.uk,
	akpm@linux-foundation.org, keescook@chromium.org, bp@alien8.de,
	vgoyal@redhat.com
Subject: About support XZ-compressed kernel on x86
Date: Fri, 12 Feb 2016 23:34:07 +0800	[thread overview]
Message-ID: <20160212153407.GA2731@x1.redhat.com> (raw)

Hi Lasse,

I am checking a thread related to kaslr and setup_data issue on x86:
https://lkml.org/lkml/2015/7/7/963

Now I have a question about the commit from you:

commit 303148045aac34b70db722a54e5ad94a3a6625c6
Author: Lasse Collin <lasse.collin@tukaani.org>
Date:   Wed Jan 12 17:01:24 2011 -0800

    x86: support XZ-compressed kernel


In this commit for adding support of XZ-compressed kernel on x86, you
add extra 32K to the extract_offset. In commit log you said this is
because "The XZ decompressor needs around 30 KiB of heap, so the heap
size is increased to 32 KiB on both x86-32 and x86-64." With my
understanding decompression is done in decompression stage and it uses
boot_heap in arch/x86/boot/compressed/head_64.S, and boot_heap is
assigned to free_mem_ptr which is used for decompression heap malloc.
During this decompressio stage it's still in copied ZO space, why did
you add extra 32K space to extract_offset?  If you want to increase the
decompression heap space shouldn't you decrease the extract_offset? Do I
misunderstand anything or miss things?

Please help answer, I really don't understand this.

Thanks
Baoquan

             reply	other threads:[~2016-02-12 15:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 15:34 Baoquan He [this message]
2016-02-12 15:41 ` About support XZ-compressed kernel on x86 Baoquan He
2016-02-13 18:57 ` Lasse Collin
2016-02-14 13:31   ` Baoquan He
2016-02-15 20:26     ` Lasse Collin
2016-02-16 13:20       ` Baoquan He
2016-02-17 17:57         ` Lasse Collin
2016-02-18  0:48           ` Baoquan He
2016-02-19 20:19             ` Lasse Collin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160212153407.GA2731@x1.redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alain@knaff.lu \
    --cc=albin.tonnerre@free-electrons.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=lasse.collin@tukaani.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillip@lougher.demon.co.uk \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.