From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aULep-0006gA-W9 for qemu-devel@nongnu.org; Fri, 12 Feb 2016 16:53:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aULem-0005VA-9x for qemu-devel@nongnu.org; Fri, 12 Feb 2016 16:53:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aULem-0005Up-1l for qemu-devel@nongnu.org; Fri, 12 Feb 2016 16:53:40 -0500 Date: Fri, 12 Feb 2016 21:53:35 +0000 From: "Daniel P. Berrange" Message-ID: <20160212215335.GA17543@redhat.com> References: <1452873871-138914-1-git-send-email-pbonzini@redhat.com> <1452873871-138914-16-git-send-email-pbonzini@redhat.com> <56A077B9.3030209@reactos.org> <20160121085619.GB19835@redhat.com> <87y4apq3fh.fsf@blackfin.pond.sub.org> <20160212165410.GN24725@redhat.com> <87io1t97jl.fsf@blackfin.pond.sub.org> <20160212180459.GQ24725@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160212180459.GQ24725@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 14/15] qemu-char: add logfile facility to all chardev backends Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , =?utf-8?B?SGVydsOp?= Poussineau , qemu-devel@nongnu.org On Fri, Feb 12, 2016 at 06:04:59PM +0000, Daniel P. Berrange wrote: > On Fri, Feb 12, 2016 at 06:12:46PM +0100, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > >=20 > > > On Fri, Feb 12, 2016 at 05:49:38PM +0100, Markus Armbruster wrote: > > >> "Daniel P. Berrange" writes: > > >>=20 > > >> > On Thu, Jan 21, 2016 at 07:16:25AM +0100, Herv=C3=A9 Poussineau = wrote: > > >> >> Hi, > > >> >>=20 > > >> >> This patch (commit d0d7708ba29cbcc343364a46bff981e0ff88366f) re= gresses the following command line: > > >> >> qemu-system-i386 -nodefaults -chardev vc,id=3Dmon0 -mon chardev= =3Dmon0 > > >> >>=20 > > >> >> Before: > > >> >> [nothing is print on console] > > >> >>=20 > > >> >> After: > > >> >> QEMU 2.5.50 monitor - type 'help' for more information > > >> >> (qemu) > > >> >>=20 > > >> >> In both cases, a working vc is created in the GTK+ UI. > > >> >>=20 > > >> >> Reverting the commit (and fixing the trivial conflict) makes th= ings > > >> >> work again. > > >> > > > >> > Thanks for the heads-up, I'll investigate and submit a fix > > >>=20 > > >> For the record, it also breaks ivshmem-test when the slow tests ar= e > > >> included. I'd be willing to test your fix; got a pointer for me? > > > > > > https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg02738.html > >=20 > > No luck. Please try the following reproducer: > >=20 > > $ make tests/ivshmem-test > > $ QTEST_QEMU_BINARY=3D'x86_64-softmmu/qemu-system-x86_64' QTEST_QEM= U_IMG=3Dqemu-img MALLOC_PERTURB_=3D${MALLOC_PERTURB_:-$((RANDOM % 255 + 1= ))} gtester -k --verbose -m slow tests/ivshmem-test >=20 > Yes, I can reproduce that. Will put it on my todo list for next week. So I investigated this, and my commit here is not the cause. My commit introduced a crash bug due to NULL pointer reference. This was fixed already in by Marc-Andre in commit 9940c3236f318949c92099163281d5d23a9fcf4f Author: Marc-Andr=C3=A9 Lureau Date: Mon Dec 21 12:10:13 2015 +0100 ivshmem: use a single eventfd callback, get rid of CharDriver I bisected the test failure again and found this change to blame: commit 428c3ece97179557f2753071fb0ca97a03437267 Author: Stefano Stabellini Date: Wed Jan 13 14:59:09 2016 +0000 fix MSI injection on Xen which makes more sense, because the test case failure you identified is specifically with the MSI code in ivshmem Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|