From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix
Date: Fri, 12 Feb 2016 22:49:34 +0100 [thread overview]
Message-ID: <20160212224934.32cd9661@free-electrons.com> (raw)
In-Reply-To: <1455304949-16808-1-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Fri, 12 Feb 2016 20:22:29 +0100, Bernd Kuhls wrote:
> -#if defined(__GLIBC__) && __GLIBC_PREREQ(2, 11)
> -+#if defined(__GLIBC__)
> -+# if __GLIBC_PREREQ(2,11)
> ++#if defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 11)
If you put both on the same line, aren't we back to the musl build
issue, where testing if a macro is defined *and* using it in the same
condition doesn't work ?
Did you verify this solution with a build against a musl toolchain ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-12 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 19:22 [Buildroot] [PATCH v2 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix Bernd Kuhls
2016-02-12 21:49 ` Thomas Petazzoni [this message]
2016-02-13 15:33 ` Bernd Kuhls
2016-02-13 16:31 ` Thomas Petazzoni
2016-02-13 17:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212224934.32cd9661@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.