From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [Bridge] hw csum failure introduced in linux-4.2
Date: Sat, 13 Feb 2016 03:35:28 +0100 [thread overview]
Message-ID: <20160213023528.GC7093@otheros> (raw)
In-Reply-To: <56A2AF73.2090204@gmail.com>
Hi Alvaro,
Did you have a chance to narrow it down to that commit yet? Would
be great if you could check whether reverting the following
commits helps:
c2d4fbd2163e ("bridge: fix igmpv3 / mldv2 report parsing")
a516993f0ac1 ("net: fix wrong skb_get() usage / crash in IGMP/MLD parsing code")
9afd85c9e455 ("net: Export IGMP/MLD message validation code")
Or reverting all of the above plus:
3c9e4f870012 ("bridge: multicast: call skb_checksum_{simple_, }validate")
Will try to get my hands on a Pi 2, too.
Regards, Linus
PS: 4.4.0 did not have c2d4fb yet, that was added with 4.4.1. While
missing it does cause trouble, it should not cause a csum error.
On Fri, Jan 22, 2016 at 11:38:43PM +0100, Álvaro Fernández Rojas wrote:
> Yes, I could reproduce it on OpenWrt using linux-4.4 on a Raspberry Pi 2.
> https://gist.github.com/Noltari/5b1cfdecce5ed4bc08fd
>
> No, I didn't open any issue on the kernel bugzilla.
> If you want me to report it somewhere else I don't have any problem with it.
>
> Regards,
> Álvaro.
>
> El 22/01/2016 a las 22:10, Stephen Hemminger escribió:
> > On Fri, 22 Jan 2016 22:03:55 +0100
> > Álvaro Fernández Rojas <noltari@gmail.com> wrote:
> >
> >> From linux-4.2 there's a "hw csum failure" for bridges using hardware
> >> checksums when IPv6 multicast traffic is received.
> >>
> >> Here are some reports:
> >> https://lkml.org/lkml/2015/12/1/699
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1266601
> >> https://discourse.osmc.tv/t/hw-csum-failure/9990
> >> https://github.com/raspberrypi/linux/issues/1259
> >>
> >> I think it may have been introduced in commit
> >> 9afd85c9e4552b276e2f4cfefd622bdeeffbbf26 (net: Export IGMP/MLD message
> >> validation code) but I haven't done any tests to confirm it.
> >> Any help on this issue would be really appreciated.
> >>
> >> Regards,
> >> Álvaro.
> > What hardware? You missed the kernel bugzilla? If it was reported
> > there I would have forwarded it to netdev@vger.kernel.org.
> >
> > Can you reproduce it with 4.4?
>
next prev parent reply other threads:[~2016-02-13 2:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 21:03 [Bridge] hw csum failure introduced in linux-4.2 Álvaro Fernández Rojas
2016-01-22 21:10 ` Stephen Hemminger
2016-01-22 22:38 ` Álvaro Fernández Rojas
2016-02-13 2:35 ` Linus Lüssing [this message]
2016-02-14 11:57 ` Linus Lüssing
2016-02-14 12:20 ` Álvaro Fernández Rojas
2016-02-15 2:10 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160213023528.GC7093@otheros \
--to=linus.luessing@c0d3.blue \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=noltari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.