From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:38551 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbcBNEG5 (ORCPT ); Sat, 13 Feb 2016 23:06:57 -0500 Date: Sun, 14 Feb 2016 04:06:53 +0000 From: Al Viro To: Mike Marshall Cc: Martin Brandenburg , Linus Torvalds , linux-fsdevel , Stephen Rothwell , Ingo Molnar Subject: Re: [RFC] slot allocator - waitqueue use review needed (Re: Orangefs ABI documentation) Message-ID: <20160214040653.GW17997@ZenIV.linux.org.uk> References: <20160209231328.GK17997@ZenIV.linux.org.uk> <20160211004432.GM17997@ZenIV.linux.org.uk> <20160212042757.GP17997@ZenIV.linux.org.uk> <20160213174738.GR17997@ZenIV.linux.org.uk> <20160214025615.GU17997@ZenIV.linux.org.uk> <20160214034608.GV17997@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160214034608.GV17997@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Feb 14, 2016 at 03:46:08AM +0000, Al Viro wrote: > #if 0 > // the trouble is, there's no wait_event_interruptible_timeout_locked() Sorry - it's wait_event_interruptible_timeout_locked_exclusive(). IOW, the open-coded variant is doing the right thing, ifdefed-out one needs s/wait_event_interruptible_timeout_locked/&_exclusive/...