From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57124)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aUqRs-0005QO-V3
	for qemu-devel@nongnu.org; Sun, 14 Feb 2016 01:46:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aUqRs-0000O9-5x
	for qemu-devel@nongnu.org; Sun, 14 Feb 2016 01:46:24 -0500
Date: Sun, 14 Feb 2016 14:46:13 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160214064613.GA31933@ad.usersys.redhat.com>
References: <1455318392-26765-1-git-send-email-jsnow@redhat.com>
	<1455318392-26765-2-git-send-email-jsnow@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1455318392-26765-2-git-send-email-jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size
	configurable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Fri, 02/12 18:06, John Snow wrote:
>  typedef struct CowRequest {
> @@ -46,6 +43,8 @@ typedef struct BackupBlockJob {
>      CoRwlock flush_rwlock;
>      uint64_t sectors_read;
>      HBitmap *bitmap;
> +    int64_t cluster_size;
> +    int64_t sectors_per_cluster;

I don't think it makes sense to duplicate one value in two units.

Fam