From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aV79j-00013j-Mq for qemu-devel@nongnu.org; Sun, 14 Feb 2016 19:36:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aV79f-0003Tg-MC for qemu-devel@nongnu.org; Sun, 14 Feb 2016 19:36:47 -0500 Date: Mon, 15 Feb 2016 11:25:32 +1100 From: David Gibson Message-ID: <20160215002532.GK2732@voom.fritz.box> References: <1454877256-22138-1-git-send-email-hpoussin@reactos.org> <56C0CF1C.4010006@ilande.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eWmFpGZayiNrn4FL" Content-Disposition: inline In-Reply-To: <56C0CF1C.4010006@ilande.co.uk> Subject: Re: [Qemu-devel] [PATCH v2 00/13] cuda: misc fixes and cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: qemu-ppc@nongnu.org, Alyssa Milburn , =?iso-8859-1?Q?Herv=E9?= Poussineau , qemu-devel@nongnu.org, Alexander Graf --eWmFpGZayiNrn4FL Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 14, 2016 at 07:01:48PM +0000, Mark Cave-Ayland wrote: > On 07/02/16 20:34, Herv=E9 Poussineau wrote: >=20 > > Hi, > >=20 > > This patchset cleans up a little bit the Apple CUDA emulation: > > - correctly reject commands with wrong parameters > > - support changing the frequency of auto-polling > > - support changing device list probed in auto-poll > > - add logs when using FILE_SERVER_FLAG/SET_POWER_MESSAGE > > - remove unused commands (GET/SET_6805_ADDR) > > - remove unimplemented GET_SET_IIC/COMBINED_FORMAT_IIC > >=20 > > GET_SET_IIC/COMBINED_FORMAT_IIC commands should be added again once > > we implement the I2C bus provided by CUDA. > >=20 > > Herv=E9 > >=20 > > Herv=E9 Poussineau (13): > > cuda: add a framework to handle commands > > cuda: move unknown commands reject out of switch > > cuda: port AUTOPOLL command to new framework > > cuda: port SET_AUTO_RATE command to new framework > > cuda: port SET_DEVICE_LIST command to new framework > > cuda: port POWERDOWN command to new framework > > cuda: port RESET_SYSTEM command to new framework > > cuda: port FILE_SERVER_FLAG command to new framework > > cuda: port SET_POWER_MESSAGES command to new framework > > cuda: port GET_TIME command to new framework > > cuda: port SET_TIME command to new framework > > cuda: remove GET_6805_ADDR command > > cuda: remove CUDA_GET_SET_IIC/CUDA_COMBINED_FORMAT_IIC commands > >=20 > > hw/input/adb.c | 18 ++-- > > hw/misc/macio/cuda.c | 279 ++++++++++++++++++++++++++++++++++++-----= -------- > > hw/ppc/mac.h | 2 + > > include/hw/input/adb.h | 2 +- > > 4 files changed, 217 insertions(+), 84 deletions(-) >=20 > Reviewed-by: Mark Cave-Ayland >=20 > This looks good to me, and again passes all my local tests. The only > thing I noticed was that there were no changes related to > qemu_log_mask() as per David's comments on patch 2 but other than that I > think this patchset is fine to merge for 2.6. Thanks for this, I've merged the series to ppc-for-2.6. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --eWmFpGZayiNrn4FL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWwRr8AAoJEGw4ysog2bOS1gkQAK3cmKBeftDg5iB5qglLWHOH vNQIMAiOFW2DluDKAAoiJ29brQtNVko7HlxMwZoRAGfo0S1GKP/JrvbGr3WtZCe1 Pe+1FoTdORQTZE23KQIFDEnutfXt1FB0VazLKirjCCEAEIoUDjP19n3ZrcV7Y5Pg 7DSH8n74hKhnAFazPEVHbbBmuHsmkdyGyz8yAAsybiDTFvhBmohuZ87Ggtxa7QH9 sV7FWgj4HhG0WYW/GR+nG7NyPDGI31wnQO7HUMXpSjSyBOcHr/xFV8Hg21BDXfmv FJ+5jxi0k+0vi1VWZUgyOlWc1QdJ0M28WVZwFmKGIrBdwVnLU0bEFtGTJDrOUJZn gVxGBkFexTxtgXWNP06+h22jh1oHXoeZ/yoqCbLfwzwkHd4Fp4UJhvCSyEgoEZ4n CQiVsKna6kFciQeWKjKF1JXB7iYM+0tx9uif/l3q6mLyI0Ju++KhQVjcydkd0d3O VZx/B7pZmDhh3hWjo7VxnGybWUVnNKxcjvrgjaoqK8ZFMxMxsiD2i7yxvPO21e/Z m5ydI9FeJnqMlhWfV6nJRgJd7o7WqhgAPpEs7gqSf1GGyEqw76s7yvff7J7VeHSS Lbdw6+N1jhFQWCQ6jenrcAq9MF3B0c6naww/zesOiGJxCcDjYqFoosEB5DPwSL21 iqNOcIhqomXwf+4/JNFv =RR6Q -----END PGP SIGNATURE----- --eWmFpGZayiNrn4FL--