All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/2] Staging: rtl8188eu: core: Remove NULL test before vfree
Date: Sun, 14 Feb 2016 16:41:02 -0800	[thread overview]
Message-ID: <20160215004102.GC1276@kroah.com> (raw)
In-Reply-To: <8ffdece306380770381595cfef73aeb8bb324c36.1455470452.git.bhumirks@gmail.com>

On Sun, Feb 14, 2016 at 11:09:30PM +0530, Bhumika Goyal wrote:
> The function vfree tests whether the argument is NULL and returns
> immediately. So NULL test before vfree is not needed. Also remove braces
> around if branch as they are no longer needed.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> Changes since v1:
> *Correct errors in commit message.
> *Remove braces around if branch.

You sent 2 patches with identical subject lines, I can't take that :(

Please add the filename to the subject to make it more obvious, and
unique.

thanks,

greg k-h


  reply	other threads:[~2016-02-15  0:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-14 17:39 [PATCH v2 0/2] Staging: rtl8188eu: core: Remove NULL test before vfree Bhumika Goyal
2016-02-14 17:39 ` [PATCH v2 1/2] " Bhumika Goyal
2016-02-15  0:41   ` Greg KH [this message]
2016-02-14 17:39 ` [PATCH v2 2/2] " Bhumika Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160215004102.GC1276@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhumirks@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.