Re: [Outreachy kernel] [PATCH] staging: most: hdm-dim2: Use devm_ functions

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Feb 13, 2016 at 11:18:01PM +0530, Amitoj Kaur Chawla wrote:
> Devm_ functions allocate memory that is released when a driver
> detaches. Replace kzalloc, ioremap and request_irq with their devm_*
> counterparts in the probe function of a platform device which were
> originally freed in the remove function.
> 
> Also, unnecessary labels have been removed and header file
> linux/device.h has been added to ensure devm_* routine declarations
> are unambiguously available.

That's a lot to just do in one patch :(

Do only one conversion at a time, and be _VERY_ careful about the
request_irq() change, that has some tricky side-affects if you don't
watch out.  If you don't know about the side affects, don't make the
change please.

So please break this up into different patches, and no need for the
device.h change, that's not needed at all.

thanks,

greg k-h