All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Layton <jlayton@poochiereds.net>,
	Eryu Guan <guaneryu@gmail.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Jan Kara <jack@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [BUG] inotify_add_watch/inotify_rm_watch loops trigger oom
Date: Sun, 14 Feb 2016 22:01:55 -0800	[thread overview]
Message-ID: <20160215060155.GV6719@linux.vnet.ibm.com> (raw)
In-Reply-To: <CA+55aFwYitXrmROWsf6+ddjctaNSe=ZtWC4MCYjCgJJJmV3LKw@mail.gmail.com>

On Sun, Feb 14, 2016 at 06:33:25PM -0800, Linus Torvalds wrote:
> On Sun, Feb 14, 2016 at 5:02 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> >
> > One thought would be to add an "emergency mode" to SRCU similar to that
> > already in RCU.  Something to the effect that if the current list of
> > callbacks is going to take more than a second to drain at the configured
> > per-jiffy rate, just process them without waiting.
> >
> > Would that help in this case, or am I missing something about the
> > reproducer?
> 
> Let's see if we can avoid srcu callbacks entirely as per Jeff, that
> would be the best option.

Agreed, no point in adding complication without use cases.

							Thanx, Paul


      reply	other threads:[~2016-02-15  6:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-14  8:35 [BUG] inotify_add_watch/inotify_rm_watch loops trigger oom Eryu Guan
2016-02-14 14:39 ` Jeff Layton
2016-02-15  1:02   ` Paul E. McKenney
2016-02-15  1:24     ` Jeff Layton
2016-02-15  2:33     ` Linus Torvalds
2016-02-15  6:01       ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160215060155.GV6719@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=guaneryu@gmail.com \
    --cc=jack@suse.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.