From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH v8 2/4] ethdev: Fill speed capability bitmaps in the PMDs Date: Mon, 15 Feb 2016 09:43:21 +0100 Message-ID: <20160215084321.GK14424@autoinstall.dev.6wind.com> References: <1454028127-10401-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-3-git-send-email-marcdevel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Marc Sune Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 8C32E95D1 for ; Mon, 15 Feb 2016 09:43:41 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id g62so138903614wme.0 for ; Mon, 15 Feb 2016 00:43:41 -0800 (PST) Content-Disposition: inline In-Reply-To: <1455488259-1000-3-git-send-email-marcdevel@gmail.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Feb 14, 2016 at 11:17:37PM +0100, Marc Sune wrote: > Added speed capabilities to all pmds supporting physical NICs: >=20 > * e1000 > * ixgbe > * i40 > * bnx2x > * cxgbe > * mlx4 > * mlx5 > * nfp > * fm10k >[...] > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_eth= dev.c > index 1159fa3..99dac09 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -523,6 +523,11 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct= rte_eth_dev_info *info) > * size if it is not fixed. > * The API should be updated to solve this problem. */ > info->reta_size =3D priv->ind_table_max_size; > + > + info->speed_capa =3D ETH_SPEED_CAP_1G | ETH_SPEED_CAP_10G | > + ETH_SPEED_CAP_10G | ETH_SPEED_CAP_40G | > + ETH_SPEED_CAP_56G; > + > priv_unlock(priv); > } Hi Marc, I have a question about this information, is it a list of the capabilities of the family or the capability of the NIC? Because with ConnectX4 family we have a range of NICs which does not support all this kind of speeds. The speeds above are not completed the range is 1/10/25/40/50/100G. --=20 N=E9lio Laranjeiro 6WIND