All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Stefano Stabellini <Stefano.Stabellini@citrix.com>,
	"aneesh.kumar@linux.vnet.ibm.com"
	<aneesh.kumar@linux.vnet.ibm.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	"gkurz@linux.vnet.ibm.com" <gkurz@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests
Date: Mon, 15 Feb 2016 13:16:21 +0000	[thread overview]
Message-ID: <20160215131621.GL8818@citrix.com> (raw)
In-Reply-To: <3fbbf2a606a14f708655037f5e4fb31e@AMSPEX02CL03.citrite.net>

On Mon, Feb 15, 2016 at 09:07:13AM +0000, Paul Durrant wrote:
> > 
[...]
> > # Option 2: Invent a xen-9p device
> > 
> > Another way of doing it is to expose a dummy xen-9p device, so that we
> > can use -fsdev XXX -device xen-9p,YYY.  This simple device should be
> > used to capture the parameters like mount_tag and fsdev_id, and then
> > chained itself to a known location.  Later Xen transport can traverse
> > this known location. This xen-9p device doesn't seem to fit well into
> > the hierarchy. The best I can think of its parent should be
> > TYPE_DEVICE.  In this case:
> > 
> > 1. Toolstack arranges some xenstore entries.
> > 2. Toolstack arranges command line options for QEMU:
> >       -fsdev XXX -device xen-9p,XXX
> > 3. QEMU starts up in xen-attach mode, scans xenstore for relevant
> >    entries, then traverses the known location.
> > 
> > Downside: Inventing a dummy device looks suboptimal to me.
> > 
> 

I wasn't talking about inventing a whole new hierarchy for XENBUS
devices. I didn't talk about that because that's not strictly related to
9p project and maybe a project in its own right.  But I'm glad you
notice this possibility.

> This sounds like a reasonable approach to me and surely it can be made
> generic (i.e. not tied to virtfs specifically). All we need as a new
> device type 'xenbus-device' or somesuch and a parameter to that device
> which specifies the exact xenstore entry for that device and all other
> configuration information is specified there e.g whether it's a vif,
> vbd, 9p or whatever. The correct backend can then be kicked off
> directly. No scanning required. No stealing required.  As for the
> device type, would it not be best to have a proper XENBUS bus type?

Yes, that would be good. It's just not implemented yet.

> All the code which actually talks to xenstore could be collected there
> and then you could have all XENBUS_DEVICEs using that common code via
> the class hierarchy?
> 

I can have a look into this. We can probably start with 9p and gradually
graft all other devices to XENBUS device hierarchy. I don't think all
other PV devices are in dire need for this hierarchy at the moment.

Wei.

>   Paul

  parent reply	other threads:[~2016-02-15 13:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 19:10 [Qemu-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests Wei Liu
2016-02-15  9:07 ` Paul Durrant
2016-02-15 13:16   ` Wei Liu
2016-02-15 13:16   ` Wei Liu [this message]
2016-02-15 13:23     ` Paul Durrant
2016-02-15 13:23     ` Paul Durrant
2016-02-15 13:33     ` [Qemu-devel] [Xen-devel] " Juergen Gross
2016-02-15 13:44       ` Wei Liu
2016-03-07  7:21         ` [Qemu-devel] " Juergen Gross
2016-03-07  7:21         ` [Qemu-devel] [Xen-devel] " Juergen Gross
2016-03-07 10:51           ` Wei Liu
2016-03-07 10:56             ` [Qemu-devel] " Juergen Gross
2016-03-07 10:56             ` [Qemu-devel] [Xen-devel] " Juergen Gross
2016-03-07 10:59               ` Wei Liu
2016-03-07 10:59               ` [Qemu-devel] " Wei Liu
2016-03-07 10:51           ` Wei Liu
2016-02-15 13:44       ` Wei Liu
2016-02-15 13:33     ` Juergen Gross
2016-02-15  9:07 ` Paul Durrant
2016-02-15 17:07 ` Stefano Stabellini
2016-02-15 17:07 ` [Qemu-devel] " Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160215131621.GL8818@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=Stefano.Stabellini@citrix.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=anthony.perard@citrix.com \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.