From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH v8 3/5] libxl: add support for vscsi Date: Mon, 15 Feb 2016 16:24:38 +0100 Message-ID: <20160215152438.GA9048@aepfle.de> References: <1455205411-25460-1-git-send-email-olaf@aepfle.de> <1455205411-25460-4-git-send-email-olaf@aepfle.de> <20160212172748.GA8818@citrix.com> <20160212182459.GA28852@aepfle.de> <20160215151610.GC10489@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160215151610.GC10489@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Stefano Stabellini , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, Feb 15, Wei Liu wrote: > > I think yes, DEFINE_DEVICES_ADD has to be used somewhere. > I'm confused. You're joking, right? "Has to be used somewhere" is not > a justification for having it in this particular place. What would be the appropriate place? I think its there since I started working on it at 4.4 times. Olaf