From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: xen-devel@lists.xensource.com
Subject: git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches
Date: Mon, 15 Feb 2016 11:00:58 -0500 [thread overview]
Message-ID: <20160215160057.GA4308@char.us.oracle.com> (raw)
Hey,
I wanted to ask what folks would think of expanding the Wiki to include (making it a diff
for simpler) this change. With my giant 30 set of patches that not only CC-ed
xen-devel twice but had some patches CC some maintainers but not others - I figured
it may be good to describe this in the Wiki:
--- orig 2016-02-15 10:45:27.719204371 -0500
+++ new 2016-02-15 10:58:33.113755665 -0500
@@ -140,7 +140,35 @@
* The maintainers are listed in the MAINTAINERS file at the top of the Xen source tree. If no maintainer is listed then there is no need for a CC (if you are modifying code with no maintainer then you might like to consider becoming the maintainer for that piece of code!).
** You can pipe your patch to the <code>./scripts/get_maintainer.pl</code> tool and it will list the relevant maintainers.
* In addition to CCing the maintainer you should always send patches to (via TO) the xen-devel@lists.xenproject.org mailing list as well.
-* To add a CC when sending the mail you can use the ''--cc'' option to the ''git send-email'' command, or you can do it manually in your MUA.
+* To add a CC when sending the mail you can:
+ * use the ''--cc'' option to the ''git send-email'' command - however if your
+ patchset is to multiple maintainers - you may end up sending all of the
+ patches to all maintainers - where some of them have no interest in
+ viewing them (as they are not under their responsibility).
+ * edit each patch to have the proper maintainer on the CC list by adding:
+<pre>
+CC: joe@doe.com
+</pre>
+ in the patch.
+ * or alternatively use --cc-cmd in your .gitconfig:
+<pre>
+[sendemail]
+ cc-cmd = scripts/get_maintainer.pl --remove-duplicates --no-l
+</pre>
+which will automatically add the proper maintainer on the CC line.
+The ''no-l'' is to not add the mailing list to the CC (as you would
+be adding that via the TO - see above)
+ * or you can do it manually in your MUA.
+
+In short, it could look like this:
+<pre>
+$pwd
+/home/joedoe/xen
+git send-email --to xen-devel@lists.xenproject.org --to jo@doe.com --compose --subject "[PATCH v1] Fixes to frobnicator." *.patch
+</pre>
+
+Which will send all patches to yourself on the TO, to xen-devel mailiing list (on the TO:)
+and the patches will have their CC: list generated based on scripts/get_maintainer.pl.
=== Providing a git branch ===
next reply other threads:[~2016-02-15 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 16:00 Konrad Rzeszutek Wilk [this message]
2016-02-15 16:04 ` git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches Andrew Cooper
2016-02-16 13:45 ` Ian Campbell
2016-02-15 16:10 ` Roger Pau Monné
2016-02-15 16:59 ` Jan Beulich
2016-02-19 16:59 ` Konrad Rzeszutek Wilk
2016-02-15 16:21 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215160057.GA4308@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.