From: "Pali Rohár" <pali.rohar@gmail.com>
To: Mario Limonciello <mario_limonciello@dell.com>
Cc: Andy Lutomirski <luto@kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Darren Hart <dvhart@infradead.org>, Jon Eyolfson <jon@eyl.io>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH v5 4/5] dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake)
Date: Mon, 15 Feb 2016 18:37:16 +0100 [thread overview]
Message-ID: <201602151837.16114@pali> (raw)
In-Reply-To: <56C20A40.6010807@dell.com>
[-- Attachment #1: Type: Text/Plain, Size: 1307 bytes --]
On Monday 15 February 2016 18:26:24 Mario Limonciello wrote:
> On 02/15/2016 11:20 AM, Pali Rohár wrote:
> > On Monday 15 February 2016 17:32:36 Andy Lutomirski wrote:
> >> + /* Stealth mode toggle */
> >> + { KE_IGNORE, 0x155, { KEY_RESERVED } },
> >
> > Hi! Just one question, what does this "Stealth mode" means and what
> > this toggle key/button doing?
> >
> > I would propose for Laptops manufactures to revert back normal
> > nonchiclet keyboard with full 105 normal keys (with F1-F12) instead
> > inventing such useless and crappy/funny names for keys/buttons on
> > laptops which replace PgUP/PgDown/SysRq and etc...
>
> Pali,
>
> Stealth mode will "disable all lights and sounds". The event is for
> notification only. The actual change is performed by a combination
> of the BIOS and EC.
>
> There is also a BIOS setting that disables the hotkey from doing
> anything.
>
> Thanks,
Thank you! Now I can image what this line in diff means :-)
Anyway, I would propose some rule to and longer description for newly
invented hot key events which are marked as KEY_RESERVED in kernel
source code. Really sometimes it is hard to guess what it can means and
constant KEY_RESERVED does not help much more.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2016-02-15 17:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 16:32 [PATCH v5 0/5] dell fixes and Skylake updates Andy Lutomirski
2016-02-15 16:32 ` [PATCH v5 1/5] dell-wmi: Stop storing pointers to DMI tables Andy Lutomirski
2016-02-17 6:37 ` Darren Hart
2016-02-17 7:04 ` Darren Hart
2016-02-15 16:32 ` [PATCH v5 2/5] dell-wmi, dell-laptop: select DMI Andy Lutomirski
2016-02-17 6:39 ` Darren Hart
2016-02-17 20:32 ` Andy Lutomirski
2016-02-15 16:32 ` [PATCH v5 3/5] dell-wmi: Clean up hotkey table size check Andy Lutomirski
2016-02-17 6:46 ` Darren Hart
2016-02-15 16:32 ` [PATCH v5 4/5] dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake) Andy Lutomirski
2016-02-15 17:20 ` Pali Rohár
2016-02-15 17:26 ` Mario Limonciello
2016-02-15 17:37 ` Pali Rohár [this message]
2016-02-17 7:29 ` Darren Hart
2016-02-17 11:19 ` Pali Rohár
2016-02-15 16:32 ` [PATCH v5 5/5] dell-rbtn: Add a comment about the XPS 13 9350 Andy Lutomirski
2016-02-17 11:16 ` Pali Rohár
2016-02-17 13:07 ` Mario Limonciello
2016-02-23 12:01 ` Pali Rohár
2016-02-23 17:35 ` Andy Lutomirski
2016-02-23 17:42 ` Mario Limonciello
2016-02-25 10:45 ` Pali Rohár
2016-02-26 20:13 ` Darren Hart
2016-02-17 7:00 ` [PATCH v5 0/5] dell fixes and Skylake updates Darren Hart
2016-02-17 20:33 ` Andy Lutomirski
2016-02-18 5:03 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201602151837.16114@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=jon@eyl.io \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.