From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id v197si603587wmv.1.2016.02.15.17.25.18 for ; Mon, 15 Feb 2016 17:25:18 -0800 (PST) Date: Tue, 16 Feb 2016 02:25:18 +0100 From: Alexandre Belloni To: Akinobu Mita Cc: rtc-linux@googlegroups.com, Wolfgang Grandegger , Alessandro Zummo Subject: [rtc-linux] Re: [PATCH 1/4] rtc-rx8025: fix irq handler registration Message-ID: <20160216012518.GC3310@piout.net> References: <1455547749-5229-1-git-send-email-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1455547749-5229-1-git-send-email-akinobu.mita@gmail.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi, Not completely related to that patch series but I was wondering if you had access to that particular RTC. The rtc-d1307 driver claims to also support rx8025 but my guess is that is is not necessary anymore. Could you check which one we should keep? Thanks! On 15/02/2016 at 23:49:06 +0900, Akinobu Mita wrote : > When IRQ line for this chips is connected, devm_request_threaded_irq() > refuses to register irq handler with the following message. > > genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq > > Signed-off-by: Akinobu Mita > Cc: Wolfgang Grandegger > Cc: Alessandro Zummo > Cc: Alexandre Belloni > --- > drivers/rtc/rtc-rx8025.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c > index bd911ba..561248a 100644 > --- a/drivers/rtc/rtc-rx8025.c > +++ b/drivers/rtc/rtc-rx8025.c > @@ -539,8 +539,9 @@ static int rx8025_probe(struct i2c_client *client, > if (client->irq > 0) { > dev_info(&client->dev, "IRQ %d supplied\n", client->irq); > err = devm_request_threaded_irq(&client->dev, client->irq, NULL, > - rx8025_handle_irq, 0, "rx8025", > - client); > + rx8025_handle_irq, > + IRQF_ONESHOT, > + "rx8025", client); > if (err) { > dev_err(&client->dev, "unable to request IRQ, alarms disabled\n"); > client->irq = 0; > -- > 2.5.0 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.