From: Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] IB/isert: properly type the login buffer
Date: Tue, 16 Feb 2016 06:40:58 +0200 [thread overview]
Message-ID: <20160216044058.GA27580@leon.nu> (raw)
In-Reply-To: <1455567060-18381-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
On Mon, Feb 15, 2016 at 09:10:57PM +0100, Christoph Hellwig wrote:
>
> - isert_conn->login_buf = kzalloc(ISCSI_DEF_MAX_RECV_SEG_LEN +
> - ISER_RX_LOGIN_SIZE, GFP_KERNEL);
> - if (!isert_conn->login_buf) {
> - isert_err("Unable to allocate isert_conn->login_buf\n");
> + isert_conn->login_req_buf =
> + kzalloc(ISCSI_DEF_MAX_RECV_SEG_LEN, GFP_KERNEL);
> + if (!isert_conn->login_req_buf) {
> + isert_err("Unable to allocate isert_conn->login_req_buf\n");
Please don't print additional allocation failure messages after
kzalloc/kmalloc.
It is relevant to all places in this patch.
> return -ENOMEM;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-16 4:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 20:10 isert: convert to the new CQ API and a few random cleanups Christoph Hellwig
2016-02-15 20:10 ` [PATCH 1/4] IB/isert: properly type the login buffer Christoph Hellwig
2016-02-16 6:47 ` Or Gerlitz
[not found] ` <1455567060-18381-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-16 4:40 ` Leon Romanovsky [this message]
[not found] ` <20160216044058.GA27580-2ukJVAZIZ/Y@public.gmane.org>
2016-02-17 10:29 ` Christoph Hellwig
2016-02-16 17:19 ` Max Gurtovoy
2016-02-17 10:33 ` Christoph Hellwig
2016-02-15 20:10 ` [PATCH 2/4] IB/isert: convert to new CQ API Christoph Hellwig
2016-02-16 18:04 ` Max Gurtovoy
2016-02-17 14:18 ` Christoph Hellwig
2016-02-18 12:32 ` Max Gurtovoy
[not found] ` <1455567060-18381-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-15 20:10 ` [PATCH 3/4] IB/isert: kill struct isert_rdma_wr Christoph Hellwig
[not found] ` <1455567060-18381-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-17 9:03 ` Max Gurtovoy
2016-02-15 20:11 ` [PATCH 4/4] IB/isert: the kill ->isert_cmd back pointer in the struct iser_tx_desc Christoph Hellwig
2016-02-17 9:31 ` Max Gurtovoy
2016-02-17 14:19 ` Christoph Hellwig
2016-02-16 10:53 ` isert: convert to the new CQ API and a few random cleanups Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216044058.GA27580@leon.nu \
--to=leon-2ukjvaziz/y@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.