From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVcUW-0001MS-JO for qemu-devel@nongnu.org; Tue, 16 Feb 2016 05:04:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVcUV-0008JB-Ci for qemu-devel@nongnu.org; Tue, 16 Feb 2016 05:04:20 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:35324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVcUU-0008Hx-Os for qemu-devel@nongnu.org; Tue, 16 Feb 2016 05:04:19 -0500 Date: Tue, 16 Feb 2016 16:48:34 +1100 From: David Gibson Message-ID: <20160216054834.GM2269@voom.redhat.com> References: <1455556228-232720-1-git-send-email-imammedo@redhat.com> <878u2lhi8i.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9ToWwKEyhugL+MAz" Content-Disposition: inline In-Reply-To: <878u2lhi8i.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: lvivier@redhat.com, thuth@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, pbonzini@redhat.com, abologna@redhat.com, bharata@linux.vnet.ibm.com, Igor Mammedov , afaerber@suse.de --9ToWwKEyhugL+MAz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 15, 2016 at 08:43:41PM +0100, Markus Armbruster wrote: > Igor Mammedov writes: >=20 > > it will allow mgmt to query present and possible to hotplug CPUs > > it is required from a target platform that wish to support > > command to set board specific MachineClass.possible_cpus() hook, > > which will return a list of possible CPUs with options > > that would be needed for hotplugging possible CPUs. > > > > For RFC there are: > > 'arch_id': 'int' - mandatory unique CPU number, > > for x86 it's APIC ID for ARM it's MPIDR > > 'type': 'str' - CPU object type for usage with device_add > > > > and a set of optional fields that would allows mgmt tools > > to know at what granularity and where a new CPU could be > > hotplugged; > > [node],[socket],[core],[thread] > > Hopefully that should cover needs for CPU hotplug porposes for > > magor targets and we can extend structure in future adding > > more fields if it will be needed. > > > > also for present CPUs there is a 'cpu_link' field which > > would allow mgmt inspect whatever object/abstraction > > the target platform considers as CPU object. > > > > For RFC purposes implements only for x86 target so far. >=20 > Adding ad hoc queries as we go won't scale. Could this be solved by a > generic introspection interface? That's my main concern as well. Igor, did you see my post with a proposal for how to organize hotpluggable packages of CPUs? I believe that would also solve the problem at hand here, by having a standard QOM location with discoverable cpu objects. The interface in your patch in particular would *not* solve the problem of advertising to management layers what the granularity of CPU hotplug is, which we absolutely need for Power. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --9ToWwKEyhugL+MAz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWwrgyAAoJEGw4ysog2bOSAB4QAJHDX0aZtgeM1r0QVS5DISH7 n80ns7DWZ3uyWQvFPQ9+35ckVZduFLCUPlsR0YhRfzyG/nxuzW6Jyt80FQAAyCPx vmsIO8b0i5ASDcCfqS6EjUcec7vH0fkJluLFtiWBXIgdZEKwSjtVRrMA2e0Hi4xR Ru5F2TvX4oodDQ5ZK8nyMBlPDKoyh660uTYTyAh9QavUOvsgE9B4aE0+cimYXt8B h3eaGhsoTancKmNA338Pv4flUqnwiYxUDVaM7+VuskeeFwI/XXPH9DRyr3zMbGud E05ofnjD0gX00sf/w2vyWVGRXcimQLEaEvPbiBfVnTCDFPu/DMKymo/1wORsQ+RD 1uDEzWzRdpPOzDl502e/Yfm4RVzP9rsMxPu/YiheAE23BZPxlRaz3Cpn2Dm2NY2F u4c1BDm9D3cR3dpBRpnqOBYzIHTbpzOFB9wsyt6uGBbTwdOe7RHPvgYqLPlmWvxk /NqxmsJMRbitC0mREosUlZ7Hw9ZyWpSL8GgsBeDooy+0oT+abrAz3f/fuUfk+sqU vxAo3FrQKSTc+IrK0YYmVoOPoS6QuRnNW03BPJHcvzjWb5DLwN0hyT6Yg207Uinl VBWWuyA/ve0SJ1QXdZ74LpvN9Rl1gH5kzsW91TzRz8gFqLx7xmyg3fmMkeAJi02+ Gfrr+awtn6cP62ZqJnBf =gD/7 -----END PGP SIGNATURE----- --9ToWwKEyhugL+MAz--