From: Eva Rachel Retuya <eraretuya@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/2] staging: wilc1000: Remove whitespace checkpatch errors
Date: Tue, 16 Feb 2016 15:30:00 +0800 [thread overview]
Message-ID: <20160216072957.GA4367@Socrates-Mint> (raw)
In-Reply-To: <20160216021948.GB31337@kroah.com>
On Mon, Feb 15, 2016 at 06:19:48PM -0800, Greg KH wrote:
> On Mon, Feb 15, 2016 at 01:34:16PM +0800, Eva Rachel Retuya wrote:
> > Address the following checkpatch errors concerning whitespace:
> > * ERROR: trailing whitespace
> > * ERROR: space required after that ',' (ctx:VxV)
> > * ERROR: spaces prohibited around that '->' (ctx:WxV)
>
> That's different things, please break this up, because:
>
> >
> > Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
> > ---
> > drivers/staging/wilc1000/host_interface.c | 2 +-
> > drivers/staging/wilc1000/linux_mon.c | 2 +-
> > drivers/staging/wilc1000/wilc_spi.c | 9 ++++++---
> > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
> > 4 files changed, 9 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> > index d1eedfb..04337c7 100644
> > --- a/drivers/staging/wilc1000/host_interface.c
> > +++ b/drivers/staging/wilc1000/host_interface.c
> > @@ -3352,7 +3352,7 @@ static s32 host_int_get_assoc_res_info(struct wilc_vif *vif,
> > PRINT_ER("Failed to send association response config packet\n");
> > return -EINVAL;
> > }
> > -
> > +
> > *pu32RcvdAssocRespInfoLen = wid.size;
> > return result;
> > }
> > diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
> > index 21f35d7..9fcb497 100644
> > --- a/drivers/staging/wilc1000/linux_mon.c
> > +++ b/drivers/staging/wilc1000/linux_mon.c
> > @@ -302,7 +302,7 @@ struct net_device *WILC_WFI_init_mon_interface(const char *name, struct net_devi
> > struct WILC_WFI_mon_priv *priv;
> >
> > /*If monitor interface is already initialized, return it*/
> > - if (wilc_wfi_mon)
> > + if (wilc_wfi_mon)
> > return wilc_wfi_mon;
> >
> > wilc_wfi_mon = alloc_etherdev(sizeof(struct WILC_WFI_mon_priv));
> > diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
> > index 2928712..339956e 100644
> > --- a/drivers/staging/wilc1000/wilc_spi.c
> > +++ b/drivers/staging/wilc1000/wilc_spi.c
> > @@ -514,7 +514,8 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz,
> > crc[0] = rb[rix++];
> > crc[1] = rb[rix++];
> > } else {
> > - dev_err(&spi->dev,"buffer overrun when reading crc.\n");
> > + dev_err(&spi->dev,
> > + "buffer overrun when reading crc.\n");
>
> That change is not ok, leave it as-is.
>
> > result = N_FAIL;
> > return result;
> > }
> > @@ -680,7 +681,8 @@ static int spi_data_write(struct wilc *wilc, u8 *b, u32 sz)
> > **/
> > if (!g_spi.crc_off) {
> > if (wilc_spi_tx(wilc, crc, 2)) {
> > - dev_err(&spi->dev,"Failed data block crc write, bus error...\n");
> > + dev_err(&spi->dev,
> > + "Failed data block crc write, bus error...\n");
>
> Same here.
>
> > result = N_FAIL;
> > break;
> > }
> > @@ -1074,7 +1076,8 @@ static int wilc_spi_clear_int_ext(struct wilc *wilc, u32 val)
> > ret = wilc_spi_write_reg(wilc,
> > WILC_VMM_CORE_CTL, 1);
> > if (!ret) {
> > - dev_err(&spi->dev,"fail write reg vmm_core_ctl...\n");
> > + dev_err(&spi->dev,
> > + "fail write reg vmm_core_ctl...\n");
>
> Same here.
>
>
>
> > goto _fail_;
> > }
> > }
> > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> > index 81a2ee9..46c6e32 100644
> > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> > @@ -2126,7 +2126,7 @@ static int start_ap(struct wiphy *wiphy, struct net_device *dev,
> >
> > priv = wiphy_priv(wiphy);
> > vif = netdev_priv(dev);
> > - wl = vif ->wilc;
> > + wl = vif->wilc;
>
> That's just odd. The original code compiles?
>
> thanks,
>
> greg k-h
Yes the original code compiles. I used 'make -j2' and also 'make
drivers/staging/wilc1000'. The latter produced the .o files fine.
I will break down the patch as you suggested.
Thanks,
Eva
next prev parent reply other threads:[~2016-02-16 7:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 5:34 [PATCH v2 0/2] staging: wilc1000: fix checkpatch errors Eva Rachel Retuya
2016-02-15 5:34 ` [PATCH v2 1/2] staging: wilc1000: Remove whitespace " Eva Rachel Retuya
2016-02-16 2:19 ` [Outreachy kernel] " Greg KH
2016-02-16 7:30 ` Eva Rachel Retuya [this message]
2016-02-16 9:52 ` Julia Lawall
2016-02-15 5:34 ` [PATCH v2 2/2] staging: wilc1000: Remove initialization of static variables Eva Rachel Retuya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216072957.GA4367@Socrates-Mint \
--to=eraretuya@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.