From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Chen Yucong <slaoub@gmail.com>,
tglx@linutronix.de, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/kernel: use pr_<level>() and dev_<level>
Date: Tue, 16 Feb 2016 09:24:31 +0100 [thread overview]
Message-ID: <20160216082431.GA3335@gmail.com> (raw)
In-Reply-To: <20160214140808.GB32622@pd.tnic>
* Borislav Petkov <bp@alien8.de> wrote:
> > @@ -70,10 +70,10 @@ do { \
> > if (!(len)) \
> > break; \
> > \
> > - printk(KERN_DEBUG fmt, ##args); \
> > + pr_debug(fmt, ##args); \
> > for (j = 0; j < (len) - 1; j++) \
> > - printk(KERN_CONT "%02hhx ", buf[j]); \
> > - printk(KERN_CONT "%02hhx\n", buf[j]); \
> > + pr_cont("%02hhx ", buf[j]); \
> > + pr_cont("%02hhx\n", buf[j]); \
> > } \
> > } while (0)
> >
>
> NAK the hell out of that hunk!
>
> Did you actually look at how pr_debug() is defined?
>
> Yeah, I don't think so. With your change, when I boot with
> "debug-alternative" I get:
>
> ...
> [ 0.064005] Last level dTLB entries: 4KB 512, 2MB 255, 4MB 127, 1GB 0
> [ 0.068005] e9 d5 3e d3 00
> [ 0.072004] e9 e8 92 21 ff
> [ 0.075003] eb 11 0f 1f 00
> [ 0.077906] e8 c5 b6 30 00
> [ 0.084009] f3 48 0f b8 c7
Hm, so I suspect the other patch I already applied is buggy as well?
triton:~/tip> git log -1 -p 1b74dde7c47c | grep KERN_DEBUG
- printk(KERN_DEBUG "tseg: %010llx\n", tseg);
- printk(KERN_DEBUG "CPU%d: Thermal monitoring handled by SMI\n", cpu);
-#define Dprintk(x...) do { if (debug_print) printk(KERN_DEBUG x); } while (0)
- printk(KERN_DEBUG "After WB checking\n");
- printk(KERN_DEBUG "MTRR MAP PFN: %016llx - %016llx\n",
- printk(KERN_DEBUG "After UC checking\n");
- printk(KERN_DEBUG "MTRR MAP PFN: %016llx - %016llx\n",
- printk(KERN_DEBUG "After sorting\n");
- printk(KERN_DEBUG "MTRR MAP PFN: %016llx - %016llx\n",
- printk(KERN_DEBUG "reg %d, base: %ld%cB, range: %ld%cB, type %s\n",
- printk(KERN_DEBUG "original variable MTRRs\n");
- printk(KERN_DEBUG "New variable MTRRs\n");
- printk(KERN_DEBUG "New variable MTRRs\n");
- printk(KERN_DEBUG "Failed to setup IBS LVT offset, "
- printk(KERN_DEBUG "No CPU node configured for IBS\n");
- printk(KERN_DEBUG "No EILVT entry available\n");
Thanks,
Ingo
next prev parent reply other threads:[~2016-02-16 8:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 4:10 [PATCH v2] x86/kernel: use pr_<level>() and dev_<level> Chen Yucong
2016-02-14 4:22 ` kbuild test robot
2016-02-14 5:07 ` kbuild test robot
2016-02-14 14:08 ` Borislav Petkov
2016-02-16 8:24 ` Ingo Molnar [this message]
2016-02-16 9:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216082431.GA3335@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=slaoub@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.